Ffaker bump #6324
Closed
Ffaker bump #6324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've prepared a stage to preview changes. Open stage or view logs. |
| sequence(:random_string) { Faker::Lorem.sentence } | ||
| sequence(:random_description) { Faker::Lorem.paragraphs(1 + Kernel.rand(5)).join("\n") } | ||
| sequence(:random_email) { Faker::Internet.email } | ||
| sequence(:random_string) { FFaker::Lorem.sentence } |
|
Hey -- do you want me to tackle the style issues in this diff? |
|
Yea that would be great. |
| @@ -5,7 +5,7 @@ | |||
| shipping_category = Spree::ShippingCategory.find_by_name!("Default") | |||
|
|
|||
| default_attrs = { | |||
| :description => Faker::Lorem.paragraph, | |||
| :description => FFaker::Lorem.paragraph, | |||
|
@JDutil I fixed the hound issues, although they wre pretty unrelated to my change. Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FFaker at versio 2.0 namespaces itself to FFaker, instead of overriding the Faker namespace used by the similar/related faker gem. (ffaker/ffaker#179)
This allows other rails apps using Spree to also use faker without getting namespace collisions.