Remove invalid call to $.css. Fixes #6319. #6651
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spree@94127f5 introduces a bug by calling $.css without arguments. For details see https://api.jquery.com/css/ .
|
I've prepared a stage to preview changes. Open stage or view logs. |
|
You should probably try a re-build at circleci, the error seems to stem from db deadlock. |
|
Yeah, I also think you should try a re-build. (I could not do that, but probably @polarblau can) |
JDutil
pushed a commit
to JDutil/spree
that referenced
this pull request
Aug 5, 2015
spree@94127f5 introduces a bug by calling $.css without arguments. For details see https://api.jquery.com/css/ . Fixes spree#6651
|
Thanks |
|
👍 |
yushine
pushed a commit
to yushine/spree
that referenced
this pull request
Dec 8, 2015
spree@94127f5 introduces a bug by calling $.css without arguments. For details see https://api.jquery.com/css/ . Fixes spree#6651
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
94127f5 introduces a bug by calling $.css without arguments. For details see https://api.jquery.com/css/ .
Fixed at eurucamp 2015 😍 in collaboration with @robinboening for https://rubyissues.ongoodbits.