Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect to last taxon permalink #6875

Closed

Conversation

berkes
Copy link

@berkes berkes commented Nov 9, 2015

In addition to #6873, add redirecting on old taxons to new permalink.

All options options can be found in docs, witch is linked to from this
file.
See also @radar's comment: spree@e145a16#commitcomment-7183062
This allows taxons to change the permalink and have an old permalink in
place.
@TeatroIO
Copy link

TeatroIO commented Nov 9, 2015

I've prepared a stage to preview changes. Open stage or view logs.

return redirect_to url_for(params), status: :moved_permanently
end
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra empty line detected at class body end.

…iven.

This mimics the behaviour of slugs in products.
@berkes berkes force-pushed the redirect-to-last-taxon-permalink branch from 6c18f0c to c74a73d Compare November 9, 2015 15:51
@damianlegawiec
Copy link
Member

Hi @berkes could you rebase this and make a PR for master?

@berkes
Copy link
Author

berkes commented Mar 2, 2016

Sure,

I'm only working on- and off on this project, so it might take a week or
two untill I have room to revisit this.

Op 28-02-16 om 22:41 schreef Damian Legawiec:

Hi @berkes https://github.com/berkes could you rebase this and make a
PR for master?


Reply to this email directly or view it on GitHub
#6875 (comment).

http://berk.es
@berkes

Open Source Webdevelopment.
Ruby on Rails development.

I only check my mail in the morning, afternoon and evening.
So please note that it may take a while for me to answer.

Ik controleer mijn mail enkel in de ochtend, middag en avond.
Het kan dus enige tijd duren voor u een antwoord van mij krijgt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants