Get rid of all the role related logic in Spree::Admin::UsersController #7004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix Bug - Upon unsuccessful form submission - the state of roles reverts * Fix Bug - Upon unsuccessful form submission - password confirmation shows error but does not highlight in red
Bharat311
force-pushed
the
cleanup-users-controller
branch
from
83b8896
to
a55016d
Compare
|
👍 |
Mafi88
added a commit
that referenced
this pull request
Feb 10, 2016
Get rid of all the role related logic in Spree::Admin::UsersController
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR - Spree::Admin::UsersController has been cleaned up.
All the roles related extra code has been removed by making use of collection_check_boxes helper.
Following 2 bugs have been fixed: