Remove unnecessary method closed? #7016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -73,10 +73,6 @@ class Adjustment < Spree::Base | |||
| extend DisplayMoney | |||
| money_methods :amount | |||
|
|
|||
| def closed? | |||
There was a problem hiding this comment.
@siddharth28 - We are using this method here - https://github.com/siddharth28/spree/blob/master/core/app/models/spree/adjustment.rb#L88.
There was a problem hiding this comment.
@siddharth28 - Or if there is something I am missing, can you provide a description?
|
@nishant-cyro added description. |
|
👍 |
1 similar comment
|
👍 |
Mafi88
added a commit
that referenced
this pull request
Feb 10, 2016
Remove unnecessary method closed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
state_machineprovides this following boolean method.Also did not remove specs so that the functioning of this method can be verified.