Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate unused Shipment methods #8106

Merged
merged 3 commits into from Jul 7, 2017
Merged

Deprecate unused Shipment methods #8106

merged 3 commits into from Jul 7, 2017

Commits on Jul 7, 2017

  1. Deprecate Shipment#editable_by? 

    This is a leftover of Spree 1.0.0 times, when we didn't use cancancan
for authorizations
    @damianlegawiec
    damianlegawiec committed Jul 7, 2017
    Copy the full SHA
    b1e738a View commit details
    Browse the repository at this point in the history

  2. Deprecate Shipment#send_shipped_email 

    This method is the same as ShipmentHandler#send_shipped_email
Operations like this should be handler by ShipmentHandler
    @damianlegawiec
    damianlegawiec committed Jul 7, 2017
    Copy the full SHA
    3398fe1 View commit details
    Browse the repository at this point in the history

  3. [skip ci] Added note about Shipment methods deprecation in 3.3 releas… 

    …e notes
    @damianlegawiec
    damianlegawiec committed Jul 7, 2017
    Copy the full SHA
    4d5f6bc View commit details
    Browse the repository at this point in the history