Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move functions checking for gem availability to core #578

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wjwitek
Copy link
Contributor

@wjwitek wjwitek commented Feb 10, 2023

Move functions checking for spree components of out spree_auth_devise and to spree/core since they will be used in other places and we don't want to copy and paste them.

@@ -1,11 +1,14 @@
require 'devise'
require 'devise-encryptable'
require 'pry'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
require 'pry'

I don't think we'll need that 😬

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ups 😮

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants