You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the ConsulDiscoveryClient.getInstances() is called, and the service is registered within consul with the secure=true tag being set, the returned ServiceInstance is not flagged as secure.
From looking at the ConsulServiceInstance, it appears that getSecure(healthService) is only checking the Metadata, however I believe it should be checking both the metadata and the tags.
The reason I believe it should be both is because our Spring Cloud Gateway instances (Spring Boot 2.3.9, Spring Cloud Hoxton.SR9) is registering itself with consul, and Spring Cloud Consul Discovery is registering and setting that secure=true tag and not setting any metadata.
Edit: I realize after looking a bit more, this may be by design and PR #700 could resolve it once completed.
The text was updated successfully, but these errors were encountered:
Specifically using:
When the
ConsulDiscoveryClient.getInstances()
is called, and the service is registered within consul with thesecure=true
tag being set, the returnedServiceInstance
is not flagged as secure.From looking at the
ConsulServiceInstance
, it appears thatgetSecure(healthService)
is only checking the Metadata, however I believe it should be checking both the metadata and the tags.The reason I believe it should be both is because our Spring Cloud Gateway instances (Spring Boot 2.3.9, Spring Cloud Hoxton.SR9) is registering itself with consul, and Spring Cloud Consul Discovery is registering and setting that
secure=true
tag and not setting any metadata.Edit: I realize after looking a bit more, this may be by design and PR #700 could resolve it once completed.
The text was updated successfully, but these errors were encountered: