-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command line args support for tasks #503
Comments
Right need to think this more for stream vs. tasks. Did some hacking locally with tasks:
But arguments option as is doesn't really fit well with stream modules. |
--params possibly (would match what we did for XD). |
Reason I went with
and this option would only add |
Anyway, I'm fine with |
Given ho vital this is for tasks, are there any objections to getting this in for the task side now and address streams later? |
Common ground was just brought in by @markpollack. As task is fundamentally different than stream, I personally don't see no problem having |
- Modify shell 'task launch' command to accept raw 'params' option for java fatjar arguments. - Modify TaskDeploymentController to accept a list of arguments to be passed into SPI's `AppDeploymentRequest`. - Added one test and had to modify mockito ArgumentCaptor to accept 'atLeast' as otherwise other tests will capture same calls to deployer. - Fixes spring-cloud#503
I had some trouble to rebasing PR for this issue as there was bigger changes in tasks. We should probably do this post release as a new PR. |
- Modify shell launch command. - Add raw list of params throughout a chain from shell into a deployer SPI call. - Added one test verifying params. - In DefaultTaskJobService.restartJobExecution() params are coming from TaskExecution, theory at least, but this is not testable right now as we don't have restart command. - Fixes spring-cloud#503
- Modify shell launch command. - Add raw list of params throughout a chain from shell into a deployer SPI call. - Added one test verifying params. - In DefaultTaskJobService.restartJobExecution() params are coming from TaskExecution, theory at least, but this is not testable right now as we don't have restart command. - Add parsing logic to DeploymentPropertiesUtils together with tests. - Fixes spring-cloud#503
When work for spring-cloud/spring-cloud-deployer#20 is done, its wingman here needs to similar things in a shell and controllers.
The text was updated successfully, but these errors were encountered: