-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shell support for task params #525
Conversation
- Modify shell 'task launch' command to accept raw 'params' option for java fatjar arguments. - Modify TaskDeploymentController to accept a list of arguments to be passed into SPI's `AppDeploymentRequest`. - Added one test and had to modify mockito ArgumentCaptor to accept 'atLeast' as otherwise other tests will capture same calls to deployer. - Fixes spring-cloud#503
@@ -108,9 +110,10 @@ public TaskDefinitionResource create(String name, String definition) { | |||
} | |||
|
|||
@Override | |||
public void launch(String name, Map<String, String> properties) { | |||
public void launch(String name, Map<String, String> properties, List<String> arguments) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpicky but we can call these parameters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, removed wrong comments, called arguments as those go to 'java' arguments which are different than options. also in SPI those are called arguments to align same naming, but in shell params as requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change needs to be carried through out the PR.
may want to update the docs to state we support --params |
I'll check what's going on with this PR and update it to merge cleanly with current master. |
Closing this PR to make a new one post release. |
'params' option for java fatjar arguments.
to be passed into SPI's
AppDeploymentRequest
.'atLeast' as otherwise other tests will capture same calls to deployer.
Testing manually:
Having definition
normal launch will output
defining
format
viaparams