Add shell support for task params #525
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modify shell 'task launch' command to accept raw 'params' option for java fatjar arguments. - Modify TaskDeploymentController to accept a list of arguments to be passed into SPI's `AppDeploymentRequest`. - Added one test and had to modify mockito ArgumentCaptor to accept 'atLeast' as otherwise other tests will capture same calls to deployer. - Fixes spring-cloud#503
| @@ -108,9 +110,10 @@ public TaskDefinitionResource create(String name, String definition) { | |||
| } | |||
|
|
|||
| @Override | |||
| public void launch(String name, Map<String, String> properties) { | |||
| public void launch(String name, Map<String, String> properties, List<String> arguments) { | |||
There was a problem hiding this comment.
nitpicky but we can call these parameters.
There was a problem hiding this comment.
sorry, removed wrong comments, called arguments as those go to 'java' arguments which are different than options. also in SPI those are called arguments to align same naming, but in shell params as requested.
There was a problem hiding this comment.
This change needs to be carried through out the PR.
|
may want to update the docs to state we support --params |
|
I'll check what's going on with this PR and update it to merge cleanly with current master. |
|
Closing this PR to make a new one post release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'params' option for java fatjar arguments.
to be passed into SPI's
AppDeploymentRequest.'atLeast' as otherwise other tests will capture same calls to deployer.
Testing manually:
Having definition
normal launch will output
defining
formatviaparams