Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Cloud Netflix provides invalid metrics when used as a prometheus provider. #1642

Closed
jzampieron opened this issue Jan 24, 2017 · 3 comments

Comments

@jzampieron
Copy link

If the spring boot actuator metrics are to be used with certain metrics engines, then the names of the metrics need to be namespaced so that duplicates are not provided.

This is an integration issue between Spring Cloud and the Prometheus Java Client for Spring Boot. Both sides have determined that its a semantic understanding problem of the APIs and should be fixed by the custom collectors.

See:
prometheus/client_java#130
and
spring-projects/spring-boot#6404

@spencergibb
Copy link
Member

And what would need to change in spring cloud?

@peter-fe
Copy link

Spring Boot has updated their documentation regarding the public metrics Interface.

See:
spring-projects/spring-boot@98a4c72

Is there any additional information needed, I may can provide?

Best regards
Peter

@spencergibb
Copy link
Member

Closing this due to inactivity. Please re-open if there's more to discuss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants