Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review checkstyle overrides #1534

Closed
sabbyanandan opened this issue Nov 21, 2018 · 1 comment
Closed

Review checkstyle overrides #1534

sabbyanandan opened this issue Nov 21, 2018 · 1 comment
Assignees
@olegz @sobychacko
Labels
task
Milestone
Horsham.M2

Comments

@sabbyanandan
Copy link
Contributor

It'd be better to remove explicit overrides in favor of what's coming from spring-cloud-build. Depending on what comes out of it, we would have to do the same in Kafka, Rabbit and others.
@sabbyanandan sabbyanandan added this to the 2.1.0.RELEASE milestone Nov 21, 2018
@sabbyanandan sabbyanandan assigned olegz and unassigned olegz Dec 4, 2018
@sabbyanandan sabbyanandan modified the milestones: 2.1.0.RELEASE, 2.2.x Jan 2, 2019
@sabbyanandan sabbyanandan removed this from the 2.2.x milestone Jan 15, 2019
@olegz olegz added the task label Jan 22, 2019
@olegz
Copy link
Contributor

olegz commented Jun 10, 2019

This has already been addressed and "spring-cloud-stream-tools" is no longer part of the process.
I'll remove it and will close the issue

@olegz olegz added this to the Horsham.M2 milestone Jun 12, 2019
olegz added a commit to olegz/spring-cloud-stream that referenced this issue Jun 12, 2019
@olegz
spring-cloudGH-1534 removing spring-cloud-stream-tools
18e1f80
@olegz olegz closed this as completed Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olegz olegz

@sobychacko sobychacko

Labels
task
Projects
None yet
Milestone
Horsham.M2
Development

No branches or pull requests
3 participants
@olegz @sobychacko @sabbyanandan