Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractMessageChannelBinder should also handle DisposableBeans #953

Closed
mbogoevici opened this issue May 10, 2017 · 0 comments
Closed

AbstractMessageChannelBinder should also handle DisposableBeans #953

mbogoevici opened this issue May 10, 2017 · 0 comments
Assignees
@mbogoevici
Milestone
1.2.2.RELEASE

Comments

@mbogoevici
Copy link
Contributor

See the related issue reported in the JMS binder spring-attic/spring-cloud-stream-binder-jms#27.

If the lifecycle object passed to the Binding is a DisposableBean we can clear it during unbinding.
@mbogoevici mbogoevici mentioned this issue May 10, 2017
Closed
@mbogoevici mbogoevici added this to the 1.2.2.RELEASE milestone May 10, 2017
mbogoevici added a commit to mbogoevici/spring-cloud-stream that referenced this issue May 11, 2017
@mbogoevici
AbstractMessageChanelBinder observes Disposable
8bd8220 
- If the endpoints produced by `createConsumer` or
  `createProducers` and Spring `DisposableBean` instances
  then call `Destroy` on unbind.

Fix spring-cloud#953
@mbogoevici mbogoevici mentioned this issue May 11, 2017
Merged
artembilan pushed a commit that referenced this issue May 12, 2017
@mbogoevici @artembilan
AbstractMessageChanelBinder observes Disposable
03f23f7 
- If the endpoints produced by `createConsumer` or
  `createProducers` and Spring `DisposableBean` instances
  then call `Destroy` on unbind.

Fix #953
@artembilan artembilan removed the in pr label May 12, 2017
mbogoevici added a commit that referenced this issue May 17, 2017
@mbogoevici
AbstractMessageChanelBinder observes Disposable
923a4b8 
- If the endpoints produced by `createConsumer` or
  `createProducers` and Spring `DisposableBean` instances
  then call `Destroy` on unbind.

Fix #953
mbogoevici added a commit that referenced this issue May 17, 2017
@mbogoevici
AbstractMessageChanelBinder observes Disposable
0ad688f 
- If the endpoints produced by `createConsumer` or
  `createProducers` and Spring `DisposableBean` instances
  then call `Destroy` on unbind.

Fix #953
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbogoevici mbogoevici

Labels
None yet
Projects
None yet
Milestone
1.2.2.RELEASE
Development

No branches or pull requests
3 participants
@mbogoevici @artembilan @sabbyanandan