Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify workflow for feedback-reminder #44

Open
snicoll opened this issue Jun 29, 2024 · 1 comment
Open

Simplify workflow for feedback-reminder #44

snicoll opened this issue Jun 29, 2024 · 1 comment

Comments

@snicoll
Copy link
Collaborator

snicoll commented Jun 29, 2024

When an issue is waiting for feedback with a reminder and someone outside the team comments on the issue, the bot removes both the waiting-for-feedback and feedback-reminder labels.

For the clock to restart, a team member must set both the waiting-for-feedback and feedback-reminder labels. If the feedback reminder label only is added, nothing really happens. This has been a source of confusion in the past, see spring-projects/spring-framework#32995 for instance.

I wonder if adding the feedback-reminder only led the bot to add the waiting-for-feedback as it needs it to operate properly. I don't know what the GitHub API lets us to do but I also wonder if re-adding the waiting-for-feedback only shouldn't add the reminder if the bot is able to figure out it was in that state.

cc @bclozel

@wilkinsona
Copy link
Collaborator

See also #23. I think it may be time to consider some broader revisions to how the feedback labels are managed by the bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants