Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share BinderConverter whenever possible #14562

Closed
philwebb opened this issue Sep 21, 2018 · 0 comments
Closed

Share BinderConverter whenever possible #14562

philwebb opened this issue Sep 21, 2018 · 0 comments
Assignees
@philwebb
Labels
theme: performance Issues related to general performance type: task A general task
Milestone
2.1.0.M4

Comments

@philwebb
Copy link
Member

Currently a few Binder instances are created early which can cause multiple BinderConverters to also be created. It's possible that for many of these early binders, we could share a single converter.

See #13565 (comment) for details.
@philwebb philwebb self-assigned this Sep 21, 2018
@philwebb philwebb added this to the 2.1.x milestone Sep 21, 2018
@philwebb philwebb added type: task A general task theme: performance Issues related to general performance labels Sep 21, 2018
@philwebb philwebb mentioned this issue Sep 21, 2018
Closed
@philwebb philwebb modified the milestones: 2.1.x, 2.1.0.M4 Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philwebb philwebb

Labels
theme: performance Issues related to general performance type: task A general task
Projects
None yet
Milestone
2.1.0.M4
Development

No branches or pull requests
1 participant
@philwebb