Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude groovy.lang.MetaClass type from configuration annotation processor #16981

Closed
dmurat opened this issue May 28, 2019 · 2 comments
Closed
Labels
type: enhancement A general enhancement
Milestone

Comments

@dmurat
Copy link

dmurat commented May 28, 2019

I have a simple Groovy Gradle project here: https://github.com/dmurat/config-annotation-processor-demo . It uses Groovy and Java classes annotated with @ConfigurationProperties. My issue is that for Groovy class annotation processor emits properties of groovy.lang.MetaClass type which is not really usefull.

I will like if groovy.lang.MetaClass can be included in a list of exclusions in org.springframework.boot.configurationprocessor.TypeExcludeFilter.

In a project mentioned above, it can be seen how metadata generation works with modifed TypeExcludeFilter. To get original behavior it is enough to switch the comments on annotationProcessor dependency in build.gradle.

Spring Boot version used is 2.1.4.RELEASE.

Tnx

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 28, 2019
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels May 28, 2019
@philwebb philwebb added this to the 2.2.x milestone May 28, 2019
@dmurat
Copy link
Author

dmurat commented May 28, 2019

I noticed that this is scheduled for 2.2.x. Can you, please, consider it for 2.1.x too?

Tnx

@philwebb philwebb added type: bug A general bug and removed type: enhancement A general enhancement labels May 28, 2019
@philwebb philwebb modified the milestones: 2.2.x, 2.1.x May 28, 2019
@philwebb philwebb added type: enhancement A general enhancement and removed type: bug A general bug labels May 28, 2019
@philwebb
Copy link
Member

It feels safe enough to consider in 2.1.x

@philwebb philwebb changed the title Exlude groovy.lang.MetaClass type from configuration annotation processor Exclude groovy.lang.MetaClass type from configuration annotation processor May 28, 2019
@philwebb philwebb modified the milestones: 2.1.x, 2.1.6 May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants