Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the Spring Maven plugin still using CF Memory Calculator? #41223

Closed
brunoborges opened this issue Jun 24, 2024 · 3 comments
Closed

Is the Spring Maven plugin still using CF Memory Calculator? #41223

brunoborges opened this issue Jun 24, 2024 · 3 comments
Labels
for: external-project For an external project and not something we can fix

Comments

@brunoborges
Copy link

brunoborges commented Jun 24, 2024

I see that the documentation points to the CF Memory Calculator. Is it still the case?

Doc: https://spring.io/guides/gs/spring-boot-docker

https://github.com/cloudfoundry/java-buildpack-memory-calculator

I wonder what is the relationship with Packeto's Buildpack: https://paketo.io/docs/howto/java/

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 24, 2024
@philwebb
Copy link
Member

I don't think that phrase is accurate anymore. I've opened spring-guides/gs-spring-boot-docker#112.

I think Paketo has a fork of the original code (https://github.com/paketo-buildpacks/libjvm/blob/main/helper/memory_calculator.go)

@philwebb philwebb closed this as not planned Won't fix, can't repro, duplicate, stale Jun 24, 2024
@philwebb philwebb added for: external-project For an external project and not something we can fix and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 24, 2024
@brunoborges
Copy link
Author

@philwebb where is the buildpack used by the Spring Maven Plugin?

@bclozel
Copy link
Member

bclozel commented Jun 25, 2024

@brunoborges We're using the paketobuildpacks/builder-jammy-base:latest builder by default, but this is something that users can configure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: external-project For an external project and not something we can fix
Projects
None yet
Development

No branches or pull requests

4 participants