Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Essential Property for Health Indicators #7626

Closed
matias2681 opened this issue Dec 12, 2016 · 1 comment
Closed

Essential Property for Health Indicators #7626

matias2681 opened this issue Dec 12, 2016 · 1 comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply

Comments

@matias2681
Copy link

It would be nice to add an optional essential property to every configuration for a health indicator. This property will allow users to indicate if the service is DEGRADED instead of DOWN. This will help in some cases where for example, a service use the database occasionally (but it doesn't depend of it 100% of the time) and if the connection to the db fails the overall status of the service will be DEGRADED instead of DOWN.

When essential=true that health indicator will behave as now. If essential=false the behavior for that health indicator will pass to DEGRADED instead of DOWN.

Probably the default behavior should be essential=true.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 12, 2016
@philwebb philwebb added type: enhancement A general enhancement for: team-attention An issue we'd like other members of the team to review and removed status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement for: team-attention An issue we'd like other members of the team to review labels Dec 12, 2016
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 16, 2016
@philwebb
Copy link
Member

Thanks for the suggestion but after some careful consideration we've decided that we'd prefer to keep things as they are. The current system is easy to understand and if non-essential HealthIndicators are needed the HealthAggregator interface can be used to implement a custom strategy.

@philwebb philwebb added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 16, 2016
@worldtiki worldtiki mentioned this issue Oct 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@philwebb @matias2681 @spring-projects-issues