DATACOUCH-28 - Remove explicit setting of setIncludeDocs on View queries.

[dharrigan]

Instead of always setting includeDocs to true for all View queries, it is now
the assumption that the programmer will enable this if they desire documents
to be returned on their query. The reasoning is to allow for an optimisation
when performing queries so that documents are not returned unless asked for.
This increases performance and reduces payload size in the communication from
Couchbase to the client.

-=david=-

[daschl]

@dharrigan I looked at this once more in the codebase and I know remember why I did it originally. Let's talk it through so we got an the same line..

in the findByView, I get a list of marshalled objects back, but when setIncludeDocs is not set to true always the method won't return useful data (because I have nothing to marshal from).

If you look down further, there is the queryView method which lets you access the query result directly (while still getting the exception mapping).

That's also why I force reduce to false because if you have a reduced view I can't get the object ids from the result.

[dharrigan]

Hi Michael,

Yes, I follow. It makes sense. As you say, unless includeDocs is set to true (always) in findByView, then come unmarshalling, nothing useful is produced.

I assume I should close my pull request?

-=david=-

[daschl]

If it makes sense for you now yes. Sorry I haven't realized this earlier but I couldn't identify it clearly from the last one :) .. but at least you now know how it works internally 👍

For your use case, can you work with the provided methods or do we need to implement something else to make you more productive?

[dharrigan]

Hi,

Totally fine. I was only doing this out of a wish to contribute to the project - not for myself personally :-) I saw the JIRA and thought okay, seems reasonable, I'll do a patch and see what comes from that :-)

Just an interested party :-)

-=david=-

[daschl]

cool, keep em' coming 👍