DATAMONGO-1689 Add Kotlin extensions for [Reactive]MongoOperations. #463
Conversation
| @@ -230,13 +231,93 @@ | |||
| <artifactId>spring-webmvc</artifactId> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
Should these be optional dependencies?
There was a problem hiding this comment.
Indeed, I will change that.
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <executions> |
There was a problem hiding this comment.
Can you elaborate on the need for this quite significant change in the compile settings?
There was a problem hiding this comment.
It seems to be the recommanded way to handle Kotlin + Java Maven builds.
JetBrains explantation is the following:
To compile mixed code applications Kotlin compiler should be invoked before Java compiler. In maven terms that means kotlin-maven-plugin should be run before maven-compiler-plugin using the following method, making sure that the kotlin plugin is above the maven-compiler-plugin in your pom.xml file.
sdeleuze
force-pushed
the
kotlin-extensions
branch
from
4dddb66
to
59b2ab1
Compare
|
Another thing we could do is to provide extensions with alternative function names to We should also update the |
|
I will send an updated version of this PR tomorrow with the following changes:
Could we consider inclusion in master when I will have pushed this updated PR? |
|
@sdeleuze I already started working on integrating Kotlin in this branch (https://github.com/spring-projects/spring-data-mongodb/tree/issue/DATAMONGO-1689). |
|
Ok thanks I will send the update against your branch and will answer on the spring-data-build side. |
|
Given the short amount of time before the M4 release tomorrow, I'd love to keep the build changes in this module for now. @sdeleuze do you think you can get your changes in tonight or early tomorrow morning CET? |
We now offer dedicated Kotlin extensions for MongoOperations and ReactiveMongoOperations.
Remove Kotlin specifics from pom.xml as those are managed in spring-data-build. Additionally format code, update license header, update JavaDoc and add issue reference to tests.
sdeleuze
force-pushed
the
kotlin-extensions
branch
from
59b2ab1
to
e5a8548
Compare
Bring back Maven Kotlin configuration for now + documentation fixes.
sdeleuze
force-pushed
the
kotlin-extensions
branch
from
e5a8548
to
781be77
Compare
sdeleuze
force-pushed
the
kotlin-extensions
branch
from
781be77
to
969b53c
Compare
We now offer dedicated Kotlin extensions for MongoOperations and ReactiveMongoOperations. Original pull request: #463.
Additionally format code, update license header, update JavaDoc and add issue reference to tests. Original pull request: #463.
Improve Maven Kotlin configuration for now + documentation fixes. Original pull request: #463.
Original pull request: #463.
Original pull request: #463.
Original pull request: #463.
No description provided.