Tiles-3 support [SPR-8825]

[spring-projects-issues]

mck opened SPR-8825 and commented

Tiles-3.0 requires new package with new TilesConfigurer, TilesView, and TilesViewResolver.

patch soon to come...

---

Affects: 3.0.6

Attachments:

• SPR-8825-0.1-finn.pom (6.06 kB)
• SPR-8825-0.1-finn-classes.jar (19.99 kB)

7 votes, 12 watchers

[spring-projects-issues]

mck commented

initial patch.

i'm a little lost how to configure the dependencies to use tiles-3.0.0-SNAPSHOT

[spring-projects-issues]

mck commented

"waiting for triage" means it's waiting on who to do what?

[spring-projects-issues]

Rossen Stoyanchev commented

Thanks for providing the patch. It would be helpful if you created an issue project over at the Spring Framework issue repository. You will find a template project and instructions.

Waiting for triage means no one (from the Spring Framework team) has looked at the issue in sufficient detail yet in order to prioritize it, assign a version, etc. This is a standard process for all new tickets.

[spring-projects-issues]

mck commented

It would be helpful if you created an issue project over at the Spring Framework issue repository. You will find a template project and instructions.
done.

[spring-projects-issues]

Rossen Stoyanchev commented

Thanks for putting that together. Any idea what the timeline for Tiles 3.0 is? It's clearly not going to align with Spring 3.1 at this point especially given the backwards compatibility issue.

[spring-projects-issues]

mck commented

3.2 is fine. I'll get back to you on release schedule.

[spring-projects-issues]

mck commented

there's a new cleaner version of tiles-3 to spring integration in development at https://issues.apache.org/jira/browse/TREQ-12
if that issue goes ahead this issue should be closed as 'won't fix'.

[spring-projects-issues]

mck commented

We (tiles developers) decided that we'd like to see the cleaner version from TREQ-12 accepted into the springframework codebase.
This makes more sense for us, and we'd like to see tiles-request (a clean request abstraction library that actually completely independent of tiles code) get more exposure.

Tiles-3 has been released, and this cleaner version is now available in the pull request spring-attic/spring-framework-issues#30

[spring-projects-issues]

mck commented

Attached jar and pom artifact that can be used to test spring to tiles3 integration.

[spring-projects-issues]

mck commented

How does one go about providing a patch for the docs, eg http://static.springsource.org/spring/docs/current/spring-framework-reference/html/view.html#view-tiles ?

[spring-projects-issues]

Nicolas LE BAS commented

mck did a great job of reviewing it and fixed an significant issue.

I feel however that we can still a bit by exposing fewer implementation details from Apache Tiles, making it a bit more simple and versatile. I'll be discussing it at Apache, since it involves a couple of small patches in Tiles.

In case we cannot act fast enough over there, this could be included in Spring as-is without breaking compatibility.

[spring-projects-issues]

Chris Beams commented

repro project at spring-attic/spring-framework-issues#30

[spring-projects-issues]

mck commented

intentionally added commits ( 98f67c1 and f060fa6 and ea64341c7 ) to pull request. improvements as discussed in TREQ-12.

[spring-projects-issues]

Rossen Stoyanchev commented

How does one go about providing a patch for the docs, eg http://static.springsource.org/spring/docs/current/spring-framework-reference/html/view.html#view-tiles ?

mck, now that the Spring Framework is on github, simply submit a pull request there. Note that I am reviewing the code for the pull request you submitted to the spring-framework-issues project and there is no need to re-submit the same code to the Spring Framework project. I'll take care of doing that. For future cases however (like submitting documentation updates), submit directly to the Spring Framework Github project.

I feel however that we can still a bit by exposing fewer implementation details from Apache Tiles, making it a bit more simple and versatile. I'll be discussing it at Apache, since it involves a couple of small patches in Tiles.

Nicolas, what was the outcome of that or rather what's the current state?

[spring-projects-issues]

Nicolas LE BAS commented

Nicolas, what's the current state?

We've made the necessary modifications at apache, and the tiles-request-1.0.2 release is currently in a staging repository awaiting formal approval by the PMC. It should be in maven central in a week or two.

The pull request submitted by mck is up to date.

[spring-projects-issues]

Rossen Stoyanchev commented

See commit 2a11007a04ab810b594f18517bb447a300b6074f.