SpringJUnit4ClassRunner should be thread safe #1140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the SpringJunit4ClassRunner to use a ThreadLocal to store the TestContextManager instead of using a single instance. Initial code from Bastian Voigt (BastianVoigt@a5e466e) Issue: SPR-12421
|
@mdeinum we obviously need Bastian Voigt to sign the CLA. Do you have a way to reach out to him? |
Removed unused variable. Issue: SPR-12421
|
@snicoll Not sure, as @BastianVoigt hasn't responded to the inquiries from @sbrannen for over a year. His user account is in JIRA so maybe someone can drop him an email? His initial patch was mentioned, so he should get a message about that from GitHub shouldn't he? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the SpringJunit4ClassRunner to use a ThreadLocal
to store the TestContextManager instead of using a single instance.
Initial code from Bastian Voigt (BastianVoigt@a5e466e)
Issue: SPR-12421