Add onError callback to DeferredResult #1463
Conversation
| @@ -209,7 +211,7 @@ public void complete() { | |||
|
|
|||
| @Override | |||
| public void completeWithError(Throwable failure) { | |||
| this.deferredResult.setErrorResult(failure); | |||
| // no-op | |||
| } | |||
There was a problem hiding this comment.
Couldn't we leave this as it was before? It is true that the PR removed the internal use of the method within the try-catch of ResponseBodyEmitter#sendInternal and that any errors from the container side should work as expected but a controller could also call completeWithError and the change eliminates the option to complete with error from the application side unrelated to write issues (and regression for some apps).
If a container and an application thread both try to setErrorResult at the same time DeferredResult will only accept the first. We can document to not do that after a write failure which could be one reason for a close timing. Other than application vs container side setErrorResult should be quite rare. If it does happen I'm not sure there is much we can do and in any case it implies the response is not usable.
Issue: SPR-15614
|
I agree. I updated the change. |
|
Merged, thanks! |
Issue: SPR-15614