Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Int 2049 #14

Closed
wants to merge 4 commits into from
Closed

Int 2049 #14

wants to merge 4 commits into from

Conversation

dturanski
Copy link
Contributor

Added namespace support for inbound/outbound-channel-adapter. Added SpEL support to CacheWritingMessageHandler, general cleanup.

markfisher added a commit that referenced this pull request Aug 16, 2011
  remove gemfire cfg files
  add namespace support
  add SpEL support to CacheWritingMessageHandler and general cleanup
@markfisher markfisher closed this Aug 16, 2011
garyrussell added a commit to garyrussell/spring-integration that referenced this pull request Mar 4, 2015
JIRA: https://jira.spring.io/browse/INT-3656

The optimization (when no interceptors) inadvertently removed
the `preSend` DEBUG log.

Reinstate the DEBUG log.

Also change `ChannelInterceptorList` to a `static` class.

This avoids the access method invocation each time the channel's
`logger` is used. The only `AMC` field used was the `logger`; pass
it into the `CIL` via a constructor.

Old bytecode:

       104: aload_0
       105: getfield      spring-projects#14                 // Field this$0:Lorg/springframework/integration/channel/AbstractMessageChannel;
       108: invokestatic  spring-projects#60                 // Method org/springframework/integration/channel/AbstractMessageChannel.access$1:(Lorg/springframework/integration/channel/AbstractMessageChannel;)Lorg/apache/commons/logging/Log;
       111: invokeinterface spring-projects#66,  1           // InterfaceMethod org/apache/commons/logging/Log.isDebugEnabled:()Z
       116: ifeq          157

New bytecode:

        98: aload_0
        99: getfield      spring-projects#22                 // Field logger:Lorg/apache/commons/logging/Log;
       102: invokeinterface spring-projects#60,  1           // InterfaceMethod org/apache/commons/logging/Log.isDebugEnabled:()Z
garyrussell added a commit to garyrussell/spring-integration that referenced this pull request Mar 4, 2015
JIRA: https://jira.spring.io/browse/INT-3656

The optimization (when no interceptors) inadvertently removed
the `preSend` DEBUG log.

Reinstate the DEBUG log.

Also change `ChannelInterceptorList` to a `static` class.

This avoids the access method invocation each time the channel's
`logger` is used. The only `AMC` field used was the `logger`; pass
it into the `CIL` via a constructor.

Old bytecode:

       104: aload_0
       105: getfield      spring-projects#14                 // Field this$0:Lorg/springframework/integration/channel/AbstractMessageChannel;
       108: invokestatic  spring-projects#60                 // Method org/springframework/integration/channel/AbstractMessageChannel.access$1:(Lorg/springframework/integration/channel/AbstractMessageChannel;)Lorg/apache/commons/logging/Log;
       111: invokeinterface spring-projects#66,  1           // InterfaceMethod org/apache/commons/logging/Log.isDebugEnabled:()Z
       116: ifeq          157

New bytecode:

        98: aload_0
        99: getfield      spring-projects#22                 // Field logger:Lorg/apache/commons/logging/Log;
       102: invokeinterface spring-projects#60,  1           // InterfaceMethod org/apache/commons/logging/Log.isDebugEnabled:()Z
garyrussell added a commit to garyrussell/spring-integration that referenced this pull request Mar 5, 2015
JIRA: https://jira.spring.io/browse/INT-3656

The optimization (when no interceptors) inadvertently removed
the `preSend` DEBUG log.

Reinstate the DEBUG log.

Also change `ChannelInterceptorList` to a `static` class.

This avoids the access method invocation each time the channel's
`logger` is used. The only `AMC` field used was the `logger`; pass
it into the `CIL` via a constructor.

Old bytecode:

       104: aload_0
       105: getfield      spring-projects#14                 // Field this$0:Lorg/springframework/integration/channel/AbstractMessageChannel;
       108: invokestatic  spring-projects#60                 // Method org/springframework/integration/channel/AbstractMessageChannel.access$1:(Lorg/springframework/integration/channel/AbstractMessageChannel;)Lorg/apache/commons/logging/Log;
       111: invokeinterface spring-projects#66,  1           // InterfaceMethod org/apache/commons/logging/Log.isDebugEnabled:()Z
       116: ifeq          157

New bytecode:

        98: aload_0
        99: getfield      spring-projects#22                 // Field logger:Lorg/apache/commons/logging/Log;
       102: invokeinterface spring-projects#60,  1           // InterfaceMethod org/apache/commons/logging/Log.isDebugEnabled:()Z
garyrussell added a commit to garyrussell/spring-integration that referenced this pull request Mar 5, 2015
JIRA: https://jira.spring.io/browse/INT-3656

The optimization (when no interceptors) inadvertently removed
the `preSend` DEBUG log.

Reinstate the DEBUG log.

Also change `ChannelInterceptorList` to a `static` class.

This avoids the access method invocation each time the channel's
`logger` is used. The only `AMC` field used was the `logger`; pass
it into the `CIL` via a constructor.

Old bytecode:

       104: aload_0
       105: getfield      spring-projects#14                 // Field this$0:Lorg/springframework/integration/channel/AbstractMessageChannel;
       108: invokestatic  spring-projects#60                 // Method org/springframework/integration/channel/AbstractMessageChannel.access$1:(Lorg/springframework/integration/channel/AbstractMessageChannel;)Lorg/apache/commons/logging/Log;
       111: invokeinterface spring-projects#66,  1           // InterfaceMethod org/apache/commons/logging/Log.isDebugEnabled:()Z
       116: ifeq          157

New bytecode:

        98: aload_0
        99: getfield      spring-projects#22                 // Field logger:Lorg/apache/commons/logging/Log;
       102: invokeinterface spring-projects#60,  1           // InterfaceMethod org/apache/commons/logging/Log.isDebugEnabled:()Z
garyrussell added a commit to garyrussell/spring-integration that referenced this pull request Mar 5, 2015
JIRA: https://jira.spring.io/browse/INT-3656

The optimization (when no interceptors) inadvertently removed
the `preSend` DEBUG log.

Reinstate the DEBUG log.

Also change `ChannelInterceptorList` to a `static` class.

This avoids the access method invocation each time the channel's
`logger` is used. The only `AMC` field used was the `logger`; pass
it into the `CIL` via a constructor.

Old bytecode:

       104: aload_0
       105: getfield      spring-projects#14                 // Field this$0:Lorg/springframework/integration/channel/AbstractMessageChannel;
       108: invokestatic  spring-projects#60                 // Method org/springframework/integration/channel/AbstractMessageChannel.access$1:(Lorg/springframework/integration/channel/AbstractMessageChannel;)Lorg/apache/commons/logging/Log;
       111: invokeinterface spring-projects#66,  1           // InterfaceMethod org/apache/commons/logging/Log.isDebugEnabled:()Z
       116: ifeq          157

New bytecode:

        98: aload_0
        99: getfield      spring-projects#22                 // Field logger:Lorg/apache/commons/logging/Log;
       102: invokeinterface spring-projects#60,  1           // InterfaceMethod org/apache/commons/logging/Log.isDebugEnabled:()Z
garyrussell added a commit to garyrussell/spring-integration that referenced this pull request Mar 5, 2015
JIRA: https://jira.spring.io/browse/INT-3656

The optimization (when no interceptors) inadvertently removed
the `preSend` DEBUG log.

Reinstate the DEBUG log.

Also change `ChannelInterceptorList` to a `static` class.

This avoids the access method invocation each time the channel's
`logger` is used. The only `AMC` field used was the `logger`; pass
it into the `CIL` via a constructor.

Old bytecode:

       104: aload_0
       105: getfield      spring-projects#14                 // Field this$0:Lorg/springframework/integration/channel/AbstractMessageChannel;
       108: invokestatic  spring-projects#60                 // Method org/springframework/integration/channel/AbstractMessageChannel.access$1:(Lorg/springframework/integration/channel/AbstractMessageChannel;)Lorg/apache/commons/logging/Log;
       111: invokeinterface spring-projects#66,  1           // InterfaceMethod org/apache/commons/logging/Log.isDebugEnabled:()Z
       116: ifeq          157

New bytecode:

        98: aload_0
        99: getfield      spring-projects#22                 // Field logger:Lorg/apache/commons/logging/Log;
       102: invokeinterface spring-projects#60,  1           // InterfaceMethod org/apache/commons/logging/Log.isDebugEnabled:()Z
garyrussell added a commit that referenced this pull request Mar 6, 2015
JIRA: https://jira.spring.io/browse/INT-3656

The optimization (when no interceptors) inadvertently removed
the `preSend` DEBUG log.

Reinstate the DEBUG log.

Also change `ChannelInterceptorList` to a `static` class.

This avoids the access method invocation each time the channel's
`logger` is used. The only `AMC` field used was the `logger`; pass
it into the `CIL` via a constructor.

Old bytecode:

       104: aload_0
       105: getfield      #14                 // Field this$0:Lorg/springframework/integration/channel/AbstractMessageChannel;
       108: invokestatic  #60                 // Method org/springframework/integration/channel/AbstractMessageChannel.access$1:(Lorg/springframework/integration/channel/AbstractMessageChannel;)Lorg/apache/commons/logging/Log;
       111: invokeinterface #66,  1           // InterfaceMethod org/apache/commons/logging/Log.isDebugEnabled:()Z
       116: ifeq          157

New bytecode:

        98: aload_0
        99: getfield      #22                 // Field logger:Lorg/apache/commons/logging/Log;
       102: invokeinterface #60,  1           // InterfaceMethod org/apache/commons/logging/Log.isDebugEnabled:()Z

Conflicts:
	spring-integration-core/src/main/java/org/springframework/integration/channel/AbstractMessageChannel.java
	spring-integration-core/src/main/java/org/springframework/integration/channel/AbstractPollableChannel.java
	spring-integration-core/src/test/java/org/springframework/integration/channel/QueueChannelTests.java
garyrussell pushed a commit that referenced this pull request Apr 26, 2016
Update for changes in github pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants