INT-3668: Add late-binding for GatewayProxyFB
#1418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA: https://jira.spring.io/browse/INT-3668 Note: the `defaultRequestChannel`, `defaultReplyChannel` and `errorChannel` remain as `MessageChannel` references, since they are really some global shared and it looks logical to require those channels be populated by end-user directly **Cherry-pick to 4.1.x**
|
Additional change: removed |
| @@ -311,7 +311,6 @@ public String call() throws Exception { | |||
| this.asyncSubmitListenableType = submitType.getClass(); | |||
| } | |||
| } | |||
| this.start(); | |||
There was a problem hiding this comment.
Although this is wrong, I don't think we can make this change on the backport - it could break usage outside of a Spring application context.
|
Merged and cherry-picked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.spring.io/browse/INT-3668
Note: the
defaultRequestChannel,defaultReplyChannelanderrorChannelremain asMessageChannelreferences,since they are really some global shared and it looks logical to require those channels be populated by end-user directly
Cherry-pick to 4.1.x