INT-4208: Support for AsycRestTemplate and thus noblocking IO #2043
Conversation
https://jira.spring.io/browse/INT-4208 Add AsyncRestTemplate support in HttpRequestExecutingMessageHandler and corresponding config/dsl support
| static void verifyNoAsyncRestTemplateAttributes(Element element, ParserContext parserContext) { | ||
| for (String attributeName : ASYNC_REST_TEMPLATE_REFERENCE_ATTRIBUTES) { | ||
| if (element.hasAttribute(attributeName)) { | ||
| parserContext.getReaderContext().error("When providing a 'rest-template' reference, the '" |
There was a problem hiding this comment.
"When providing an 'async-rest-template'...
Correct? To properly reflect the reality.
| @@ -33,28 +34,51 @@ | |||
| * @author Oleg Zhurakousky | |||
| * @author Gary Russell | |||
| * @author Artem Bilan | |||
| * @author Shiliang Li | |||
There was a problem hiding this comment.
Missed Copyright update in this class.
| import org.springframework.web.client.AsyncRestTemplate; | ||
|
|
||
| /** | ||
| * The {@link org.springframework.integration.dsl.MessageHandlerSpec} implementation for the {@link AsyncHttpRequestExecutingMessageHandler}. |
There was a problem hiding this comment.
This is BaseHttpMessageHandlerSpec impl.
No reason to mention the super of super.
| AsyncHttpMessageHandlerSpec(Expression uriExpression, AsyncRestTemplate asyncRestTemplate) { | ||
| this.target = new AsyncHttpRequestExecutingMessageHandler(uriExpression, asyncRestTemplate); | ||
| this.target.setUriVariableExpressions(this.uriVariableExpressions); | ||
| this.target.setHeaderMapper(this.headerMapper); |
There was a problem hiding this comment.
M-m-m. I think we have to move these to assignments to the ctor of super class.
And in that case we won't need to make those variables as protected to make Sonar Qube angry
There was a problem hiding this comment.
You mean moving the assignments to the ctor of BaseHttpMessageHandlerSpec? I have tried that but faced one problem: I still want to leave the this.target = new AsyncHttpRequestExecutingMessageHandler(uriExpression, asyncRestTemplate); to the concrete subclass to avoid reflection solution then after moving this.target.setUriVariableExpressions(this.uriVariableExpressions); this.target.setHeaderMapper(this.headerMapper); statements to BaseHttpMessageHandlerSpec will throw error due to the this.target is not initialized yet.
What you think?
There was a problem hiding this comment.
???
How about this?
protected BaseHttpMessageHandlerSpec(E handler) {
this.target = handler;
this.target.setUriVariableExpressions(this.uriVariableExpressions);
this.target.setHeaderMapper(this.headerMapper);
}
...
AsyncHttpMessageHandlerSpec(Expression uriExpression, AsyncRestTemplate asyncRestTemplate) {
super(new AsyncHttpRequestExecutingMessageHandler(uriExpression, asyncRestTemplate));
this.asyncRestTemplate = asyncRestTemplate;
}
...
HttpMessageHandlerSpec(Expression uriExpression, RestTemplate restTemplate) {
super(new HttpRequestExecutingMessageHandler(uriExpression, restTemplate));
this.restTemplate = restTemplate;
}
| return Collections.singletonList(this.headerMapper); | ||
| } | ||
|
|
||
| protected abstract boolean isRestTemplateSet(); |
There was a problem hiding this comment.
abstract in the end, after all other public` full methods.
| * @since 5.0 | ||
| */ | ||
| public class AsyncHttpRequestExecutingMessageHandler extends AbstractHttpRequestExecutingMessageHandler { | ||
| private AsyncRestTemplate asyncRestTemplate; |
There was a problem hiding this comment.
Must be final and surrounded with blank lines.
src/reference/asciidoc/http.adoc
Outdated
| </bean> | ||
| ---- | ||
|
|
||
| You can configure the AsyncClientHttpRequestFactory instance to use: |
There was a problem hiding this comment.
Consider to wrap all the classes mentioned to the code using "`" symbol.
|
Please, also mention in the commit message https://jira.spring.io/browse/INT-4076 |
https://jira.spring.io/browse/INT-4076 https://jira.spring.io/browse/INT-4208 Add AsyncRestTemplate support in HttpRequestExecutingMessageHandler and corresponding config/dsl support
|
Will clear the errors tomorrow |
https://jira.spring.io/browse/INT-4076 https://jira.spring.io/browse/INT-4208 Add AsyncRestTemplate support in HttpRequestExecutingMessageHandler and corresponding config/dsl support
https://jira.spring.io/browse/INT-4076 https://jira.spring.io/browse/INT-4208 Add AsyncRestTemplate support in HttpRequestExecutingMessageHandler and corresponding config/dsl support
|
@artembilan Thanks for hosting my first PR :) |
https://jira.spring.io/browse/INT-4208
Add AsyncRestTemplate support in HttpRequestExecutingMessageHandler and corresponding config/dsl support