INT-4573: Fix logic in the OperationInvokingMH #2763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA: https://jira.spring.io/browse/INT-4573 * Fix check order for headers first in the `resolveObjectName()` and `resolveOperationName()`. Then fallback to defaults configured on the `OperationInvokingMessageHandler` * Remove also a deprecated API in the `OperationInvokingMessageHandler` * Remove requirements for `object-name` and `operation-name` XML attributes since those options can be provided in the request message headers * Fix `OperationInvokingChannelAdapterParserTests` for proper headers resolution * Mention `JmxHeaders.OBJECT_NAME` and `JmxHeaders.OPERATION_NAME` headers in the `jmx.adoc`
garyrussell
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.spring.io/browse/INT-4573
resolveObjectName()andresolveOperationName().Then fallback to defaults configured on the
OperationInvokingMessageHandlerOperationInvokingMessageHandlerobject-nameandoperation-nameXMLattributes since those options can be provided in the request message
headers
OperationInvokingChannelAdapterParserTestsfor proper headersresolution
JmxHeaders.OBJECT_NAMEandJmxHeaders.OPERATION_NAMEheaders in the
jmx.adoc