Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-3446: Stream support in the MessageGroupStore #3466

Merged
merged 1 commit into from
Jan 20, 2021
Merged

GH-3446: Stream support in the MessageGroupStore #3466

merged 1 commit into from
Jan 20, 2021

Conversation

artembilan
Copy link
Member

Fixes #3446

  • For better resources utilization provide a Stream<Message<?>> API
    on the MessageGroupStore, MessageGroup and MessageGroupQueue
  • Use this API in the DelayHandler when it reschedules persisted messages

@artembilan
spring-projectsGH-3446: Stream support in the MessageGroupStore
b91ea3e 
Fixes spring-projects#3446

* For better resources utilization provide a `Stream<Message<?>>` API
on the `MessageGroupStore`, `MessageGroup` and `MessageGroupQueue`
* Use this API in the `DelayHandler` when it reschedules persisted messages
garyrussell
garyrussell suggested changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@garyrussell garyrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any new tests for these stream methods.

@artembilan
Copy link
Member Author

I don't see any new tests for these stream methods.

All the delayer tests against persistent message stores do their job I believe.
This is only a place where we actually use messages from the stored group.

@garyrussell garyrussell merged commit f0f2c41 into spring-projects:master Jan 20, 2021
@artembilan artembilan deleted the GH-3446 branch January 20, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyrussell garyrussell garyrussell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DelayHandler, ConfigurableMongoDbMessageStore and PersistentMessageGroup issue at startup/load
2 participants
@artembilan @garyrussell