Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit Session on Include Dispatch #1250

Closed
vpavic opened this issue Nov 2, 2018 · 0 comments
Closed

Commit Session on Include Dispatch #1250

vpavic opened this issue Nov 2, 2018 · 0 comments
Assignees
@vpavic
Labels
in: core type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug
Milestone
1.3.4

Comments

@vpavic
Copy link
Contributor

vpavic commented Nov 2, 2018

Backport of #1243.
@vpavic vpavic added type: bug A general bug in: core type: backport An issue that is a backport of another issue to a maintenance branch labels Nov 2, 2018
@vpavic vpavic added this to the 1.3.4 milestone Nov 2, 2018
@vpavic vpavic self-assigned this Nov 2, 2018
vpavic pushed a commit that referenced this issue Nov 8, 2018
@jzheaux @vpavic
Commit Session on Include Dispatch
695f2f1 
The servlet spec disallows any writing of headers after an include has been issued.

This commit intercepts the include and commits the session, then
allowing the include to proceed.

See: #1250
vpavic added a commit that referenced this issue Nov 8, 2018
@vpavic
Polish contribution
d245cc1 
Resolves: #1250
@vpavic vpavic closed this as completed Nov 8, 2018
@vpavic vpavic mentioned this issue Jan 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vpavic vpavic

Labels
in: core type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug
Projects
None yet
Milestone
1.3.4
Development

No branches or pull requests
1 participant
@vpavic