Initial support for cassandra backend #589

fitzoh · 2016-08-07T19:56:43Z

Provides a Cassandra Spring Session backend per #588, with dependencies provided via Spring Data Cassandra.

fitzoh · 2016-08-07T19:59:47Z

This is currently somewhat rough. A decent amount of cleanup and documentation is required, and it is light on unit tests.
Integration tests are copy pasted from the JDBC integration tests with some modifications, primarily around Expiration (JDBC expires sessions manually, while the Cassandra implementation makes use of TTL).

I had issues getting https://github.com/jsevellec/cassandra-unit and embedded Cassandra working, so the integration test currently depends on Cassandra running outside the process on localhost (I added Cassandra to the travis service list).

vpavic · 2016-08-09T06:11:10Z

gradle.properties

@@ -19,6 +19,8 @@ httpClientVersion=4.5.1
 jedisVersion=2.8.1
 h2Version=1.4.191
 springDataMongoVersion=1.9.1.RELEASE
+springDataCassandraVersion=1.5.0.M1


Is Ingalls milestone release really required here? Other Spring Data dependencies are on Hopper release train level ATM, so we should use 1.4.2.RELEASE.

Lowered to the stable version, which also drops the Cassandra version from 3 to 2.

Tests fail on cass3, but pass on cass2 locally.

Pretty sure this means the travis tests will be broken until I can get embedded cass working.

vpavic · 2016-08-09T06:30:19Z

I've added some comments on the code.
I guess the next step would be to add unit tests for the repository and CassandraHttpSessionConfiguration.

IMO it would be reeeally nice if you managed to get embedded Cassandra to work with integration tests.

…ver by copy pasting the class. Temporary measure until spring-projects#557 is resolved.

mp911de · 2016-08-09T12:56:31Z

...ion/src/main/java/org/springframework/session/data/cassandra/CassandraSessionRepository.java

+			insert.using(QueryBuilder.ttl(ttl));
+		}
+		catch (IllegalArgumentException e) {
+			log.info("Session has already expired, skipping save");


Performing that check eagerly might help skip conversion (serialization)

Good call, updated

mp911de · 2016-08-09T13:06:25Z

Nice approach. I added my thoughts to the PR. Besides some basic configuration, you also might want to be able to configure the consistency level to tune throughput vs. consistency.

fitzoh · 2016-08-19T12:07:03Z

Finally got Embedded Cassandra working, not sure what I was missing initially

vpavic · 2016-12-02T06:39:05Z

@jjzazuet We're currently in the RC phase of the 1.3.0 release which means this PR will be considered and more thoroughly reviewed for next releases (likely 1.4.0). Keep an eye on the assigned milestone, and the milestones page in general as an indication of release plans.

jjzazuet · 2016-12-02T14:58:35Z

@vpavic got it. Thanks!

Documentation updates

jjzazuet · 2017-03-28T14:35:15Z

Hello everyone. Just wanted to ping to check if this PR is good for the 1.4.0 release. Thanks for your time!

fitzoh · 2017-03-28T14:39:24Z

At a minimum there are some conflicts that need to be updated. I'm a little short on time at the moment, but I think I just gave you push access to my repo if you want to clean those up @jjzazuet .

jjzazuet · 2017-03-29T12:35:47Z

@fitzoh yep, I can give those a shot. Thanks!

vpavic · 2017-03-29T12:42:20Z

@jjzazuet @fitzoh You don't have to worry about conflicts, I've already taken care of that on my local branch for this PR when I started working on it. Thanks!

jjzazuet · 2017-04-01T15:16:22Z

@vpavic got it. Many thanks!

vpavic · 2017-04-28T20:49:30Z

I'm afraid we are removing this from the 1.4.0.M1.

@rwinch and I have been discussing the supported data stores over the past few weeks, and the decision was made to limit the first-class supported data stores to Redis, JDBC and Hazelcast from 2.0.x on. See #768 for more details and background. As a part of this, existing GemFire and Mongo data stores have been removed in the master and will be deprecated in 1.4.0.M1.

@fitzoh @jjzazuet we'd like to encourage you to make this effort a Spring Session community extension project. We promote such extensions in Community Extensions section of the reference manual so please open a issue/PR to list your project in there once you set it up.

Thank you for your efforts. Also thanks to @mp911de for providing his feedback on this PR.

jjzazuet · 2017-04-30T02:49:44Z

@vpavic @rwinch ay ay ay... alright... I mean, I still like the idea of keeping each data store implementation separate as per #768.

Anyway, it looks like milestone 2.0.0 M1 is nearing completion, so I guess we should target that Spring session version, right? @fitzoh , would you like me to start a spring-session-cassandra repository and prepare a Gradle build for pushing out artifacts into JCenter?

Thanks!

vpavic · 2017-06-19T17:19:04Z

@jjzazuet @fitzoh release 2.0 is a good target - note the recently merged changes to Session API (#776) as this will have some impact on your implementation.

cah-andrew-fitzgerald · 2017-06-19T17:22:05Z

@jjzazuet just realized I never replied... Yeah, feel free to prep a repo/build if you'd like.

vpavic · 2017-06-19T18:53:19Z

You can also use the newly created spring-session-data-mongodb and spring-session-data-geode repositories as references.

jjzazuet · 2017-06-20T16:58:31Z

@vpavic @cah-andrewfitzgerald alright. Yes it looks like both repositories are compiling against 2.0.0.BUILD-SNAPSHOT, so I'll give it a shot. Thanks!

fitzoh · 2018-04-04T13:48:10Z

Good news for anyone who might stumble upon this in the future:
@armeris has taken the code from the initial PR and created a standalone repo @ https://github.com/armeris/spring-session-cassandra

Initial support for cassandra backend

f0abd18

vpavic reviewed Aug 9, 2016
View reviewed changes

fitzoh added 5 commits August 9, 2016 07:22

drop dependency on JdbcOperationsSessionRepository.PrincipalNameResol…

9d474ff

…ver by copy pasting the class. Temporary measure until spring-projects#557 is resolved.

rename cassandra integration test to be more consistent

9390f1c

replace CassandraTemplate with CassandraOperations

b30ff68

remove guava dependency.

ce8c437

killing more guava deps

f45a1c1

mp911de reviewed Aug 9, 2016
View reviewed changes

change spring-data-cassandra version to 1.4.2.RELEASE (stable version)

4390d86

fitzoh force-pushed the master branch from 8d87f55 to 72f450b Compare August 19, 2016 03:10

short circuit save logic if session should already be expired

d8482d4

fitzoh force-pushed the master branch from 72f450b to d8482d4 Compare August 19, 2016 03:27

embedded cassandra working

62e4d8f

fitzoh added 3 commits September 8, 2016 00:34

rename template -> cassandraOperations

f22bab5

documentation

995f61f

checkstyle fixes

35dca6b

jjzazuet and others added 2 commits December 5, 2016 08:20

- Documentation updates.

fcf514e

Merge pull request #3 from jjzazuet/master

dd3c117

Documentation updates

vpavic modified the milestone: 1.4.0 M1 Dec 16, 2016

vpavic self-assigned this Dec 16, 2016

vpavic added Data Store type: enhancement A general enhancement and removed status: waiting-for-feedback We need additional information before we can continue labels Jan 13, 2017

vpavic added the status: on-hold label Mar 29, 2017

vpavic closed this Apr 28, 2017

vpavic removed this from the 1.4.0 M1 milestone Apr 28, 2017

vpavic added status: declined A suggestion or change that we don't feel we should currently apply and removed Data Store type: enhancement A general enhancement status: on-hold labels Apr 28, 2017

vpavic mentioned this pull request Apr 28, 2017

Support Cassandra as a Spring Session backend #588

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial support for cassandra backend #589

Initial support for cassandra backend #589

fitzoh commented Aug 7, 2016 •

edited

Loading

fitzoh commented Aug 7, 2016 •

edited

Loading

vpavic Aug 9, 2016

fitzoh Aug 9, 2016

vpavic commented Aug 9, 2016

mp911de Aug 9, 2016

fitzoh Aug 9, 2016

mp911de commented Aug 9, 2016

fitzoh commented Aug 19, 2016

vpavic commented Dec 2, 2016

jjzazuet commented Dec 2, 2016

jjzazuet commented Mar 28, 2017

fitzoh commented Mar 28, 2017 •

edited

Loading

jjzazuet commented Mar 29, 2017

vpavic commented Mar 29, 2017

jjzazuet commented Apr 1, 2017

vpavic commented Apr 28, 2017

jjzazuet commented Apr 30, 2017

vpavic commented Jun 19, 2017

cah-andrew-fitzgerald commented Jun 19, 2017

vpavic commented Jun 19, 2017

jjzazuet commented Jun 20, 2017

fitzoh commented Apr 4, 2018

Initial support for cassandra backend #589

Initial support for cassandra backend #589

Conversation

fitzoh commented Aug 7, 2016 • edited Loading

fitzoh commented Aug 7, 2016 • edited Loading

vpavic Aug 9, 2016

Choose a reason for hiding this comment

fitzoh Aug 9, 2016

Choose a reason for hiding this comment

vpavic commented Aug 9, 2016

mp911de Aug 9, 2016

Choose a reason for hiding this comment

fitzoh Aug 9, 2016

Choose a reason for hiding this comment

mp911de commented Aug 9, 2016

fitzoh commented Aug 19, 2016

vpavic commented Dec 2, 2016

jjzazuet commented Dec 2, 2016

jjzazuet commented Mar 28, 2017

fitzoh commented Mar 28, 2017 • edited Loading

jjzazuet commented Mar 29, 2017

vpavic commented Mar 29, 2017

jjzazuet commented Apr 1, 2017

vpavic commented Apr 28, 2017

jjzazuet commented Apr 30, 2017

vpavic commented Jun 19, 2017

cah-andrew-fitzgerald commented Jun 19, 2017

vpavic commented Jun 19, 2017

jjzazuet commented Jun 20, 2017

fitzoh commented Apr 4, 2018

fitzoh commented Aug 7, 2016 •

edited

Loading

fitzoh commented Aug 7, 2016 •

edited

Loading

fitzoh commented Mar 28, 2017 •

edited

Loading