Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
invalid range check for SetMapSquareTerrainType()
- Loading branch information
invalid range check for SetMapSquareTerrainType()
3f927da
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whats prefered in such a case: silently accept invalid input or give an error message?
in this case: is the error message ok or silently ignore the invalid values?
i guess i miss a common rule for the lua api, how to handle errors.
(i know, i've asked the same/similar question some time ago, but still i'm unsure when to do what)
3f927da
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error message please! Otherwise the user will just waste time trying to find what's wrong.
3f927da
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://springrts.com/phpbb/viewtopic.php?f=12&t=31878
3f927da
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is synced Lua and entirely in the responsibility of the content devs.