-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templates fail when tests are not run due to API limits #5
Comments
Oh yeah! Will publish a fix tomorrow, thanks for reporting this. :) |
Hey @akrawchyk, I've fixed your specific error and published as version 0.0.3. There may be other places where similar problems exist, I haven't done a thorough test yet. Leaving this issue open until I know that everything is okay across the board. |
Thanks for looking into this so quickly @philbooth! |
Just in case anyone is interested, work is now underway to further improve this behaviour in the https://github.com/nature/webpagetest-mapper/compare/graceful-failure?expand=1 |
Version 0.1.2 has been published which fully resolves this issue. Previously, failed tests were being left in the result array, causing gaps to show up in the charts and labels for the failed tests to be overwritten at the same offset. Now those tests are removed entirely instead. |
I have a 200 hit/day limit for WebPageTest. I configured a test with more than that many, and webpagetest-mapper did a great job of gracefully handling that:
However, after retrieving test results I run into an issue I believe is related to these API limits:
The text was updated successfully, but these errors were encountered: