PR JSR-303 support for Request Parameters + Fix 1244 Allowable values not displayed in Apidocs + 1231 Externalizing Api Descriptions

[jfiala]

Bean Validations API (JSR-303) support for Request Parameters #1227

[jfiala]

This PR fixes #1227 and #1244

[jfiala]

Cleaned up sources, now code coverage needs to get improved.

[jfiala]

Added a ApiDescriptionPropertiesReader and associated plugins (Parameter/ExpandedParameter/ModelProperty) to implement #1232

In fact, this should be moved to another module (as it has nothing to do with the validators).
Please suggest where we could move this?

[jfiala]

@dilipkrish I cleaned up the obvious codacy-bot notes, but what shall we do with "Avoid unused private fields..." regarding the test helper classes? Can you please assist here to get the PR merged eventually...?

[dilipkrish]

Sure I'll take a look at it. Sorry I din't realize adding codacy support will retroactively reviews PRs.

Also do you mind squashing the merge commits and rebasing against master plus there are merge conflicts that are probably better handled by you.

[jfiala]

@dilipkrish I rebased and now I get this (both at my forked repo and in the main repo):
gradle eclipsegrad

• What went wrong:
  A problem occurred evaluating root project 'springfox'.

  Failed to apply plugin [id 'springfox-multi-release']
  Not a valid version. Expecting a version of form <MAJOR.MINOR.PATCH> where e.g. 1.0.0-SNAPSHOT, 1.0.0-1-g10a2eg:

[dilipkrish]

Looks like its a bad rebase 😖 ... After the rebase you should only be seeing your commits in your pull request. How did you rebase?

Assuming remote origin => springfox/springfox and remote jfiala => jfiala springfox. Is this what you did

git fetch origin master # gets springfox updates
git rebase origin/master #applies your changes on top of springfox HEAD 
git push jfiala master -f #force push to your master so that your pr is updated.

[jfiala]

The PR is in order (after some local cleanups...), I get the error above when doing clean checkout of https://github.com/springfox/springfox/ as well, so it doesn't seem to have to do with my commits...

(and I only changed the springfox-bean-validators + 1 class of springfox-swagger2 - EnumMapper)

[jfiala]

If I view the differences now with jfiala:master, my branch is only 29 commits ahead of the master / 39 files changed? However, I'd like to do a clean build before I create the new PR....

[dilipkrish]

What do you see when you do a git describe?

[jfiala]

Now it looks good, after I've done gradle eclipse, the subproject springfox-spring-web lost its reference to springfox-schema and also added useless classpathentries "test", e.g. for springfox-schema:

<classpathentry kind="lib" path="C:/projects/springfox/springfox-core/build/classes/test"/>
<classpathentry kind="lib" path="C:/projects/springfox/springfox-core/build/resources/test"/>
...

After cleaning up those I can build again from springfox-master & my master as well.

[dilipkrish]

Still doesn't look right. Your PR shouldn't have my commits in it 👇

[jfiala]

created a new PR which shows the current state (only my / carlosjgp commits...).