Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for spring data rest 3.0.5.RELEASE while maintaining backward com… #2323

Conversation

deodeveloper
Copy link
Contributor

…partibility

What's this PR do/fix?

The current swagger version doesn't work with new version of spring data rest (3.0.5.RELEASE). This pull request fixes that problem while maintaining backward compatibility.

Are there unit tests? If not how should this be manually tested?

No new unit tests required for the changes, the existing unit tests have those.

Any background context you want to provide?

Swagger data rest doesn't work with new spring data rest version 3.0.5.RELEASE due to the fact that new spring version returns java 8 Optional instead of direct object.

What are the relevant issues?

Current Swagger data rest (2.8.0) doesn't work with new spring data rest version 3.0.5.RELEASE

@dilipkrish dilipkrish added the PR label Apr 13, 2018
@dilipkrish dilipkrish merged commit 43aaedb into springfox:master Apr 14, 2018
@dilipkrish
Copy link
Member

Thanks @deodeveloper! 🤘

@dilipkrish dilipkrish added this to the 2.9.0 milestone Apr 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants