Test and fix for #703: ScrollerView does not render correctly on first time #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #703 (Putting this in a comment creates a mention link between the issue and the pull request). I'm not a reviewer, but this looks good to me. Thanks! |
|
The test does not verify the offsets because I was not able to access them. Both jQuery.offset() and DOMElement.offset(Left|Top) always returned 0. Did not have the time to dig into this. |
|
I have tried the proposed fix against the 'test controls' app and it solves the issues that were visible in the scroll section. |
|
@publickeating This pull request seems very straight forward. Do you think we can sneak it into SC 1.8 ? |
publickeating
added a commit
that referenced
this pull request
Mar 6, 2012
Test and fix for #703: ScrollerView does not render correctly on first time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description necessary. :)