This repository has been archived by the owner on Sep 9, 2024. It is now read-only.
Simplify HTTP API. #107
Merged
Simplify HTTP API. #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify resource access on Kepler by reducing the endpoints to `/invoke` and `/delegate` only, and parsing the request from the invocation.
cobward
force-pushed
the
feat/invoke-api
branch
from
9972680
to
40c9ea7
Compare
cobward
force-pushed
the
feat/invoke-api
branch
from
3ad3081
to
d6160d2
Compare
chunningham
approved these changes
Apr 14, 2022
| impl_fromreq!(DelAuthWrapper, "del"); | ||
| impl_fromreq!(ListAuthWrapper, "list"); | ||
| pub enum InvokeAuthWrapper { | ||
| Create(OrbitId), |
There was a problem hiding this comment.
IMO this should be handled by DelegateAuthWrapper, but I understand this maintains the current behaviour so fair enough
There was a problem hiding this comment.
Yeah agreed. I had a go at converting it to a delegation, but I couldn't get it working. I'll put an issue in for this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify resource access on Kepler by reducing the endpoints to
/invokeand/delegateonly, and parsing the request from the invocation.This does not support invocation by only referencing a pre-submitted delegation, because that is hard and it looks like we will require the delegation going forwards anyway.