chore: Navigation layout plugin implementation #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…383-navigation-layout-plugin
2 flaky tests on run #11031 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Search suite > Products sorting > should apply all sorting options |
Test Replay
Screenshots
Video
|
|
category.cy.ts • 1 flaky test • sf-regression
| Test | Artifacts | |
|---|---|---|
| ... > should apply price filtering |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #883 ↗︎
Sinucid
suggested changes
Nov 10, 2023
libs/platform/experience/src/services/layout/plugins/properties/index.ts
Outdated
Show resolved
Hide resolved
...platform/experience/src/services/layout/plugins/types/navigation/navigation-layout.plugin.ts
Outdated
Show resolved
Hide resolved
...platform/experience/src/services/layout/plugins/types/navigation/navigation-layout.styles.ts
Outdated
Show resolved
Hide resolved
Sinucid
suggested changes
Nov 10, 2023
tobi-or-not-tobi
changed the title
tobi-or-not-tobi
changed the title
Sinucid
approved these changes
Nov 10, 2023
tobi-or-not-tobi
merged commit c0b0584
into
feature/HRZ-2519-header-navigation
20 of 23 checks passed
tobi-or-not-tobi
deleted the
feature/HRZ-90383-navigation-layout-plugin
branch
dunqan
reviewed
Nov 10, 2023
| if (exactMatch) { | ||
| return of(currentUrl === url); | ||
| } else { | ||
| return of(currentUrl.startsWith(url)); |
There was a problem hiding this comment.
there may be some edge cases, where startsWith may not always work as expected
There was a problem hiding this comment.
what edge cases?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navigation layout plugin and shadow layout property plugin.
closes: HRZ-90383 HRZ-90391 HRZ-90390