-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Navigation layout plugin implementation #883
Merged
tobi-or-not-tobi
merged 21 commits into
feature/HRZ-2519-header-navigation
from
feature/HRZ-90383-navigation-layout-plugin
Nov 10, 2023
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
ffbf258
shadow property plugin
tobi-or-not-tobi 7ef52e9
navigation layout plugin
tobi-or-not-tobi 818eae4
b2c and b2b category header
tobi-or-not-tobi d2b9bc0
add test
tobi-or-not-tobi 062893d
stylelint
tobi-or-not-tobi 092e6a0
drop stickiness on header
tobi-or-not-tobi fb27a0a
Merge branch 'feature/HRZ-2519-header-navigation' into feature/HRZ-90…
tobi-or-not-tobi ae1e294
Merge branch 'feature/HRZ-2519-header-navigation' into feature/HRZ-90…
tobi-or-not-tobi e922089
current route
tobi-or-not-tobi 3790d60
fix category mock for content link component
tobi-or-not-tobi 05026fb
vertical navigation layout
tobi-or-not-tobi 783f29e
move my account static experience data to labs
tobi-or-not-tobi ccac423
first stories
tobi-or-not-tobi 73986b2
improve shadow tokens
tobi-or-not-tobi 9eb16f6
fix
tobi-or-not-tobi 1b24a0d
drop shadow plugin
tobi-or-not-tobi ad33cf4
stylelint
tobi-or-not-tobi 1e0aee6
fixes
tobi-or-not-tobi 32a114e
fix export
tobi-or-not-tobi 951e7f8
fix
tobi-or-not-tobi 3375062
fix tests
tobi-or-not-tobi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
libs/domain/product/src/mocks/src/mock-category.service.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
import { Observable, of } from 'rxjs'; | ||
import { ProductCategory } from '../../models'; | ||
import { ProductCategoryService } from '../../services'; | ||
|
||
export class MockProductCategoryService | ||
implements Partial<ProductCategoryService> | ||
{ | ||
static mockProductsCategories: ProductCategory[] = [ | ||
{ id: '2', name: 'Cameras & Camcorders', order: 0 }, | ||
{ id: '5', name: 'Computer', order: 0 }, | ||
{ id: '9', name: 'Smart Wearables', order: 0 }, | ||
{ id: '11', name: 'Telecom & Navigation', order: 0 }, | ||
]; | ||
|
||
get(id: string): Observable<ProductCategory> { | ||
const productCategory = | ||
MockProductCategoryService.mockProductsCategories.find( | ||
(p) => p.id === id | ||
) as ProductCategory; | ||
|
||
return of(productCategory); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there may be some edge cases, where
startsWith
may not always work as expectedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what edge cases?