my account navigation #960
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Navigation layout plugin and shadow layout property plugin. closes: [HRZ-90383](https://spryker.atlassian.net/browse/HRZ-90383) [HRZ-90391](https://spryker.atlassian.net/browse/HRZ-90391) [HRZ-90390](https://spryker.atlassian.net/browse/HRZ-90390) [HRZ-90383]: https://spryker.atlassian.net/browse/HRZ-90383?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [HRZ-90391]: https://spryker.atlassian.net/browse/HRZ-90391?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [HRZ-90390]: https://spryker.atlassian.net/browse/HRZ-90390?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
we've changed the styles so that navigation styles can peers through the shadow DOM and affect the CSS of content links whether they're direct children or nested in other components (e.g. a category-list).
Test whether the category navigation contains a link to all products and whether the navigation links work. closes: [HRZ-90392](https://spryker.atlassian.net/browse/HRZ-90392) [HRZ-90392]: https://spryker.atlassian.net/browse/HRZ-90392?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
…382-category-list
❌ Deploy Preview for dev-oryx-components failed.
|
✅ Deploy Preview for dev-composable-storefront ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-fulfillment ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dunqan
reviewed
Dec 1, 2023
| import { LitElement, TemplateResult, html } from 'lit'; | ||
|
|
||
| @hydrate() | ||
| export class UserNavigationTriggerComponent extends ContentMixin(LitElement) { |
There was a problem hiding this comment.
UserAuthNavigationComponent? 🤔
Not sure, but this "navigation trigger" sounds not too clear for me...
dunqan
reviewed
Dec 1, 2023
| }, | ||
| { | ||
| type: 'oryx-content-link', | ||
| options: { |
There was a problem hiding this comment.
This one will also have to be in labs only for now
There was a problem hiding this comment.
agreed. Moved over to labs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.