chore: category navigation e2e #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-composable-storefront ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-fulfillment ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-oryx-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
1 failed test on run #11189 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Cart summary suite > counter: > should increase if a product is added from pdp |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #892 ↗︎
AndreyYevtukhov
previously requested changes
Nov 13, 2023
apps/storefront-e2e/src/support/page-fragments/category-navigation.fragment.ts
Show resolved
Hide resolved
Sinucid
suggested changes
Nov 13, 2023
tobi-or-not-tobi
changed the base branch from
development
to
feature/HRZ-2519-header-navigation
|
just discussed with @AndreyYevtukhov and we decided to drop e2e completely. We will have very soon visual regression on the storefront, which means we do not need to build this UI e2e manually. |
…2-category-navigation-e2e
…2-category-navigation-e2e
Sinucid
suggested changes
Nov 15, 2023
Sinucid
approved these changes
Nov 15, 2023
tobi-or-not-tobi
merged commit b01cb57
into
feature/HRZ-2519-header-navigation
19 of 23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test whether the category navigation contains a link to all products and whether the navigation links work.
closes: HRZ-90392