Fix:RDS:add DBParameterGroupArn in describe-db-parameter-groups & cre… #3462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate-db-parameter-group
bpandola
reviewed
Nov 12, 2020
bblommers
requested changes
Nov 16, 2020
tests/test_rds2/test_rds2.py
Outdated
| @@ -1518,6 +1520,9 @@ def test_create_db_parameter_group(): | |||
| db_parameter_group["DBParameterGroup"]["Description"].should.equal( | |||
| "test parameter group" | |||
| ) | |||
| db_parameter_group["DBParameterGroup"]["DBParameterGroupArn"].should.equal( | |||
| "arn:aws:rds:{0}:REDACTED:pg:{1}".format(region, pg_name) | |||
There was a problem hiding this comment.
The moto.core.ACCOUNT_ID has to be replaced here as well (same in the other test)
|
This is now part of moto >= 1.3.16.dev154 |
robjwilkins
pushed a commit
to robjwilkins/moto
that referenced
this pull request
Dec 7, 2020
getmoto#3462) * Fix:RDS:add DBParameterGroupArn in describe-db-parameter-groups & create-db-parameter-group * Test change * Fixed tests * tests change acconutID * linting Co-authored-by: usmankb <usman@krazybee.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix:RDS:add DBParameterGroupArn in describe-db-parameter-groups & create-db-parameter-group
localstack/localstack#3219