Add get_function_configuration support for Lambda #3562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bblommers
requested changes
Jan 7, 2021
tests/test_awslambda/test_lambda.py
Outdated
| ) | ||
| result["Version"].should.equal("$LATEST") | ||
| result["FunctionArn"].should.equal( | ||
| "arn:aws:lambda:us-west-2:{}:function:testFunction:$LATEST".format(ACCOUNT_ID) |
There was a problem hiding this comment.
The region can also be formatted, with _lambda_region
tests/test_awslambda/test_lambda.py
Outdated
| ) | ||
|
|
||
| result = conn.get_function_configuration(FunctionName="testFunction") | ||
| # this is hard to match against, so remove it |
There was a problem hiding this comment.
Don't think we need to remove these keys, as we're not verifying equality on the entire dict.
enoodle
force-pushed
the
adding_lambda_get_function_configuration
branch
from
94c88a8
to
a29238b
Compare
bblommers
requested changes
Jan 9, 2021
There was a problem hiding this comment.
Thanks for making the changes @enoodle. Looks like the linter fails atm (https://travis-ci.org/github/spulec/moto/builds/753454806) - happy to merge once that's resolved.
|
@bblommers I fixed the linting issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
boto3.client('lambda').get_function_configuration(FunctionName='blalbla')