adding layers support for lambda backend #3563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enoodle
force-pushed
the
adding_lambda_layers_support
branch
from
9962c62
to
9b12f11
Compare
enoodle
force-pushed
the
adding_lambda_layers_support
branch
from
9b12f11
to
641c5fb
Compare
bblommers
requested changes
Jan 11, 2021
There was a problem hiding this comment.
Hi @enoodle, thanks for the PR!
Could you add a CloudFormation-test as well, to verify that create_from_cloudformation_json works as expected?
Looks like the build is failing as well: https://travis-ci.org/github/spulec/moto/builds/753836363
|
@bblomers I have added those tests and fixed the formatting issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds basic support for layers to the lambda resource.
Adding support for
boto3.client('lambda').publish_layer_version(...)andboto3.client('lambda').list_layer_versions(LayerName='')and also supporting Layer information passed to functions.It does not implement all the layers API and it is not adding the layers to the lambda invocation simulation.
Fixes: #3188