-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation to put_events #3579
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @gruebel, would you mind splitting up the test scenarios in multiple methods?
Would be good to also test a scenario with multiple events, some valid, some invalid.
I also removed the weird |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's failing in Py2:
AttributeError: 'module' object has no attribute 'JSONDecodeError'
@bblommers is there actually a plan to drop Python 2 support at some point? |
There's no plan yet, @gruebel. There's still a significant portion of people that are stuck with Py2, and we want to keep Moto available to them as long as possible. |
Fixes #3384
It is a quite interesting behaviour of the
put_events
endpoint, because each event is validated separately and the status is send back for all of them.