Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Add to List for dynamodb:UpdateItem #3585

Merged
merged 1 commit into from
Jan 10, 2021

Conversation

bpandola
Copy link
Collaborator

This handles the add-to-list case using the legacy AttributeUpdates parameter.

  • Added test coverage.
  • Verified against real AWS backend.

Closes #3561

This handles the add-to-list case using the legacy `AttributeUpdates` parameter.

* Added test coverage.
* Verified against real AWS backend.

Closes getmoto#3561
@coveralls
Copy link

coveralls commented Jan 10, 2021

Coverage Status

Coverage increased (+0.0005%) to 94.569% when pulling fef7847 on bpandola:close-3561 into 6dfd64f on spulec:master.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one - thanks @bpandola!

@bblommers bblommers merged commit 640df04 into getmoto:master Jan 10, 2021
@bpandola bpandola deleted the close-3561 branch January 11, 2021 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][dynamodb2] AttributeUpdates ADD to List not implemented
3 participants