Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort s3 object versions by last_modified_on in descending order #3588

Merged
merged 5 commits into from
Jan 15, 2021

Conversation

irahulranjan
Copy link
Contributor

@coveralls
Copy link

coveralls commented Jan 14, 2021

Coverage Status

Coverage decreased (-0.004%) to 94.584% when pulling d6df914 on irahulranjan:localstack_issue_3433 into 7ff6068 on spulec:master.

@irahulranjan
Copy link
Contributor Author

Hi @bblommers, I just fixed lint issues and rebased with master and the tests started failing in an unrelated file. Can you please help me?
I don't know who to reach out to for such an issue. Thanks.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @irahulranjan, that was an intermittant failure - restarting the build fixed it.
Thanks for the PR!

@bblommers bblommers merged commit 628c026 into getmoto:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants