Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Rekognition support to include get_face_search and start_face_seach #5115

Merged

Conversation

AlanDonohoe
Copy link
Contributor

@AlanDonohoe AlanDonohoe force-pushed the add-rekognition-face-recognition branch from 32df8ab to 58363ca Compare May 10, 2022 14:02
@AlanDonohoe AlanDonohoe changed the title Extends Rekognition support to include get_face_search and start_face_seach Extend Rekognition support to include get_face_search and start_face_seach May 10, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2022

Codecov Report

Merging #5115 (58363ca) into master (ac03044) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5115   +/-   ##
=======================================
  Coverage   95.88%   95.88%           
=======================================
  Files         678      678           
  Lines       67085    67099   +14     
=======================================
+ Hits        64322    64336   +14     
  Misses       2763     2763           
Flag Coverage Δ
servertests 36.75% <21.42%> (-0.01%) ⬇️
unittests 95.82% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
moto/rekognition/models.py 100.00% <100.00%> (ø)
moto/rekognition/responses.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac03044...58363ca. Read the comment docs.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the PR @AlanDonohoe!

@bblommers bblommers merged commit ae6b28b into getmoto:master May 10, 2022
@bblommers bblommers added this to the 3.1.9 milestone May 10, 2022
@github-actions
Copy link
Contributor

This is now part of moto >= 3.1.9.dev9

@AlanDonohoe
Copy link
Contributor Author

Fantastic!

Thanks for reviewing and merging...

@AlanDonohoe AlanDonohoe deleted the add-rekognition-face-recognition branch May 11, 2022 08:48
sahilshah6196 pushed a commit to EBSCOIS/moto that referenced this pull request Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants