Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive this Repository #3

Closed
wants to merge 25 commits into from
Closed

Revive this Repository #3

wants to merge 25 commits into from

Conversation

mrclary
Copy link

@mrclary mrclary commented Mar 30, 2020

Okay guys,
I've completed all the necessary updates to bring this project back to life.
There should be a companion PR in the Spyder repository: spyder-ide/spyder#12011.
These should address #2.

Of course, your comments/changes/recommendations are encouraged.

Ryan Clary added 5 commits March 29, 2020 14:52
* move create_app.py from spyder repo to this repo
* create virtualenv requirements
* remove non-essential packages for now; restore when app works
* include wrapt fixes issue "ModuleNotFoundError: No module named 'wrapt'"
* include lazy_object_proxy fixes issue "ModuleNotFoundError: No module named 'lazy_object_proxy'"
* include spyder_kernels fixed previous kernel error
* include pyls fixed no linting warning
* Note: everything seems to be working except linting and alignment guides in editor (works with bootstrap)
* Note: pillow cannot currently be packaged with py2app; see ronaldoussoren/py2app#219. It's possible that compile/install from source may work, but that will have to be deferred.
@ccordoba12
Copy link
Member

Thanks a lot for this @mrclary!

I have one question: do you think we could create the new dmg in continuous infrastructure services?

@mrclary
Copy link
Author

mrclary commented Apr 1, 2020

Thanks a lot for this @mrclary!

You're welcome. I am happy to contribute. I've been using Spyder for many, many years now and we use it quite extensively on Macs at my company (TAE Technologies), so I'm motivated to have a standalone Mac application.

I have one question: do you think we could create the new dmg in continuous infrastructure services?

Well, I don't know anything about CI, but suppose we could.

…: internal interpreter won't work in alias mode if using virtualenv

* minimize packages outside Resources/lib/pythonXX.zip
* parse extra argument '--no-dmg' and make for flexible control of setup execution
* add option for 'lite' build
Ryan Clary added 4 commits April 3, 2020 16:36
…rces

* after pyls plugins loaded, resolved further issues by including appropriate packages
* clean-up PACKAGES
* Note: at present, only supports external interpreters with same python version as internal interpreter.
@vancromy
Copy link

vancromy commented May 7, 2020

What's the status on this revival? Is this going to be merged into master? Would be nice to have a functioning standalone application for Macs.

On a side note, I absolutely love Spyder. Keep up the great work guys.

@mrclary
Copy link
Author

mrclary commented May 7, 2020

@vancromy , thanks for the compliment!

This is absolutely being revived. At present, I don't have permissions to merge the branch and I know that the core Spyder developers are very busy. In addition, I've had to make some changes to Spyder source code to accommodate the standalone app (spyder-ide/spyder#12011, spyder-ide/spyder#12232, spyder-ide/spyder#12235, spyder-ide/spyder#12236, spyder-ide/spyder#12237, spyder-ide/spyder#12271). These are not quite ready to merge.
While I can't say when these will be merged, and I can assure you that this revival will move forward.

After these initial pull requests are completed, I'll begin working on automated build deployments, so that users will not have to build the app themselves and just download it. But one thing at a time...

Thank you for being patient :-)

@CAM-Gerlach
Copy link
Member

@ccordoba12 I imagine you'll have some comment on this :) ^

* -e flag required on pip install so that egg-info can be copied to bundle
@ccordoba12
Copy link
Member

Thanks @CAM-Gerlach for pinging me about this.

@vancromy, after seeing the great work @mrclary has done to revive this project and also noticing that about 60% (perhaps more) of our bug reports are related to installation/updating issues, we decided to (once again) distribute our own installers for macOS (and eventually Windows too).

So our plan is to release Spyder 4.1.4 at the beginning of June, then work with @mrclary to merge his PRs and start to distribute our installers along with 4.2.0, to be released (hopefully) in August.

* Force reinstall python-language-server and spyder-kernels
* Skip egg info if missing
@goanpeca
Copy link
Member

goanpeca commented Jun 8, 2020

@mrclary thanks for the continued effort in making this work! I have the PRs in the back of my bucket list and I will get to them at some point this week. Please be patient, and sorry for the delays in prividing more prompt feedback.

Ryan Clary added 4 commits June 22, 2020 14:28
* move subrepo installation to environment creation shell script
* move copy spyder repo to environment creation shell script
Note: in future make spyder a subrepo to spyder-mac-app
@mrclary
Copy link
Author

mrclary commented Oct 16, 2020

Closing this PR in favor of spyder-ide/spyder#13992

@mrclary mrclary closed this Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants