MacApp: add site-packages to jedi configuration

[mrclary]

Description of Changes

• Wrote at least one-line docstrings (for any new functions)
• Added unit test(s) covering the changes (if testable)

• Included a screenshot or animation (if affecting the UI, see Licecap)

When launching Spyder from non-conda environments, jedi does not add site-packages for target conda environments properly (see davidhalter/jedi#1540).
I've added the site-package for the target environment to the extra_paths configuration for jedi.

Issue(s) Resolved

Fixes #12259

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
@mrclary

[ccordoba12]

Great work finding the problem for this one @mrclary!

Please rebase this and all your other pending PRs so you can get the fixes to our tests.

[pep8speaks]

Hello @mrclary! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file spyder/plugins/completion/languageserver/plugin.py:

Line 639:17: E129 visually indented line with same indent as next logical line

• In the file spyder/utils/programs.py:

Line 146:13: E129 visually indented line with same indent as next logical line

Comment last updated at 2020-06-25 15:30:35 UTC

[goanpeca]

Hi @mrclary thanks for working on this. After 4.1.3 is release we are working to get all these PRs merged so we can start working also on installers on our side ;-)

Sorry for the lack of response in the past weeks. Cheers!

[goanpeca]

@mrclary is there any testing we could add for these changes?

[goanpeca]

Also this `alter_subprocess_kwargs_by_platform``

We could add a test to check that the expected values on windows are there etc.

[goanpeca]

Docstrings are sentences so let's add the period :-)

"""Get the site-packages for a given python executable."""

[goanpeca]

Looks good @mrclary

My suggestion is writing tests to check all the expected changes are in place and also add some future proofing.

Thanks!

[mrclary]

@goanpeca , thanks for reviewing the code and I'll be happy to address your suggestions. However, before I do, let me ask how 'future proof' do we want to be? This PR is just a kluge for a bug in jedi (davidhalter/jedi#1540) which is already fixed. I did not expect the changes in this PR to be permanent, but to be removed as soon as python-language-server adopts the next latest version of jedi (>0.17.0)

[goanpeca]

@mrclary so, anything that is temporal please let's add a TODO: or FIXME: tags. Also please open issue to keep track of the fix that we need to revert once jedi is updated?

For the rest that is not patch work on jedi, let's add tests :-)

[mrclary]

@mrclary so, anything that is temporal please let's add a TODO: or FIXME: tags. Also please open issue to keep track of the fix that we need to revert once jedi is updated?

For the rest that is not patch work on jedi, let's add tests :-)

Got it. I really don't see any use for get_python_site_packages outside of this kluge, so I will forgo tests for that.

[mrclary]

I think this is ready

[goanpeca]

Awesome work @mrclary !

[goanpeca]

I think this is ready @ccordoba12, should we create the 4.1.x branch and merge this to 4.x ?

[mrclary]

This PR is obsolete with the advent of Jedi 0.17.1