PR: Use clean environment for Python version and module checks (Mac app) #12235

mrclary · 2020-04-09T04:35:05Z

Description of Changes

Use a clean shell environment when obtaining python interpreter version or installed module version.

Wrote at least one-line docstrings (for any new functions)
Added unit test(s) covering the changes (if testable)

Included a screenshot or animation (if affecting the UI, see Licecap)

Currently, when checking for python version or installed module versions in subprocesses in preparation for launching a spyder_kernel, the subprocess inherits Spyder's environment variables, which can lead to incorrect results if Spyder's environment is not a conda environment (such as in a standalone Mac application). By using a clean subprocess environment, the python version and installed module versions are correctly checked.

Currently, installed module versions are checked by writing a new script to a temporary script file and running it in a python subprocess, possibly several times, depending on the version requirements. This is replaced with a much simpler, single python subprocess call to obtain the installed module version, which can be compared to the requirement(s).

Issue(s) Resolved

This allows the stand-alone Mac application to function properly.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
@mrclary

pep8speaks · 2020-04-09T04:35:08Z

Hello @mrclary! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file spyder/utils/programs.py:

Line 153:80: E501 line too long (82 > 79 characters)
Line 848:80: E501 line too long (102 > 79 characters)

Comment last updated at 2020-10-13 19:27:58 UTC

goanpeca · 2020-04-12T13:02:56Z

is envsomething that works on windows?

spyder/plugins/ipythonconsole/plugin.py

spyder/utils/programs.py

mrclary · 2020-05-09T03:44:39Z

I think this is ready

ccordoba12

Hey @mrclary, thanks for your patience with this PR! I left an initial review for you.

spyder/utils/programs.py

* installed_version only passed in from dependencies.Dependency.check, so removed it from call signature here and in dependencies.Dependency.check

…235 (comment)

* installed_version only passed in from dependencies.Dependency.check, so removed it from call signature here and in dependencies.Dependency.check

…235 (comment)

…ess gets SYSTEMROOT env variable

…te versions are extracted. * much cleaner way to check module version under given interpreter * leverage change in subprocess kwargs modification to provide platform agnostic clean environments

* installed_version only passed in from dependencies.Dependency.check, so removed it from call signature here and in dependencies.Dependency.check

…235 (comment)

ccordoba12

Thanks @mrclary, I left a couple of suggestions to improve the style of your code and fix our tests.

spyder/utils/programs.py

ccordoba12

Thanks @mrclary, looks good to me now.

…n 4.2.0 Arkadiusz Kwasigroch (4): fix create folder in a project explorer add reference to the issue fix comments remove whitespaces Benjamin Beasley (1): Call QGuiApplication.setDesktopFileName to fix generic icon on GNOME/Wayland C.A.M. Gerlach (5): Update, revise and copyedit existing tour steps Add test for tour message on first startup Fix tour dialog layout and make it consistant across platforms Right-align tour dialog buttons to match others Tweak sizes and padding so that tour dialogs match original CAM Gerlach (1): Further improve tour text based on reviewer feedback Carlos Cordoba (186): Editor: Update decorations only in the visible portion of the screen Editor: Update decorations when the scrollbar position changes Editor: Set linting results in the line number area in a thread Editor: Add a method to get the first and last visible block numbers Editor: Underline linting errors only on the visible portion of the screen Editor: Avoid updating decorations multiple times in a very short interval Back to work Update release instructions Testing: Use the PyLS subrepo in our tests LSP: Pass USERPROFILE to the PyLS because some modules require it Fix style issue Testing: Fix test_extra_selections Editor: Catch RuntimeError when updating decorations in the right place Testing: Fix LSP linting tests IPython console: Correctly import IPythonInputSplitter for IPython < 7.0 Editor: Fix cell highlighting Editor: Improve perfomance on mouse wheel by not calling highlight_current_cell on it Testing: Pin python-jsonrpc-server to a working version for now Testing: Remove pin for python-jsonrpc-server because it's not necessary anymore git subrepo pull external-deps/python-language-server Editor: Add missing Slot decorator Editor: Add constant to clearly show how much time we're waiting to update decorations Testing: Check how many times we're trying to update decorations when scrolling Editor: Minor formatting improvements Editor: Set kind attribute for all extra selections Editor: Remove method that called rehighlight_cells Editor: Remove an unnecessary call to update_extra_selections Editor: Increase size of the region in which we update decorations Editor: Add a better fix to prevent stealing focus when scrolling on it Editor: Update decorations when releasing the up/down keys Testing: Rename test file to better reflect what's testing Testing: Some improvements to decorations test Testing: Check more cases in test_decorations Update contributing guide to install main dependencies from label in our channel Testing: Pin ujson in pip tests Testing: Pull new PyLS deps from our channel Increase PyLS required version git subrepo clone --branch=develop --force https://github.com/palantir/python-language-server.git external-deps/python-language-server LSP: Remove repeated SymbolKind enum Add missing dependencies Testing: Fix test_update_decorations_when_scrolling in macOS Editor: Use update_decorations_timer when releasing up/down arrows Editor: Add comments to describe constants related to updating decorations Editor: Avoid sending petitions to the LSP before it's initialized Editor: Rename completion_server_ready to start_completion_services Editor: Rename notify_server_down to stop_completion_services Testing: Replace _ by __ as dummy variable in test_decorations Update Jedi requirement to 0.17.2 Fix link in comment Fix minor style issue IPython console: Add default values to Pdb config options Editor: Correctly set Pdb actions state at startup Testing: Fix a failing test git subrepo clone (merge) --branch=1.x --force https://github.com/spyder-ide/spyder-kernels.git external-deps/spyder-kernels git subrepo clone --branch=jedi-environment-variables --force https://github.com/mrclary/python-language-server.git external-deps/python-language-server Testing: Pin QtAwesome to 0.7.3 until we can update to 1.0.0 git subrepo clone --branch=develop --force https://github.com/palantir/python-language-server.git external-deps/python-language-server Indent guides: Remove unused imports and variables Indent guides: Paint only those inside or that cross the visible region LSP: Remove hack to avoid updating the server sys.path twice at startup Main window: Start LSP Python client after the session was loaded LSP: Connect Projects first to sig_initialize from the client Projects: Rename a couple of methods related to the LSP for clarity git subrepo clone --branch=pass-config-to-new-workspaces --force https://github.com/ccordoba12/python-language-server.git external-deps/python-language-server LSP: Send the initialized notification after receiving the initialize response LSP: Rename a method and an attribute for clarity git subrepo pull (merge) external-deps/spyder-kernels Main window: Minor style fixes LSP: Update server's sys.path only if it doesn't correspond to a project's change git subrepo pull (merge) external-deps/spyder-kernels Main window: Start completions manager right after it's created Projects: Remove extra calls to add/delete LSP workspaces Editor: Start completion services for files without a language server Testing: Fix completion tests Testing: Check that we send requests to the LSP in the right order at startup git subrepo clone --branch=develop --force https://github.com/palantir/python-language-server.git external-deps/python-language-server Internal console: Fix error when scrolling with the mouse wheel on it LSP: Use an enum to update status bar widget LSP: Add spinner to its status widget Main Window: Hide splash screen in post_visible_setup LSP: Move strings for translation to the ClientStatus enum Editor: Create Outline proxy when new code editors are created Outline: Use stored info to update it in case it's empty Outline: Update it correctly at startup when "Show all files" is activated Editor: Remove unnecessary calls to refresh the Outline Outline: Update it for cloned editors Editor: Fix errors when Outline is not present Editor: Send empty list in case documentSymbol response is None Outline: Stop spinner for untitled files Testing: Fix test_toggle_off_show_all_files CodeEditor: Restore checks for oe_proxy to avoid errors when running our tests CodeEditor: Remove Outline from test widget at the end of the file Testing: More test fixes Testing: Check Outline shows an empty tree when its associated file is emptied Outline: Update all editors at startup Outline: Start symbol services only if LSP supports them Outline: Update it only if the file's language is among the LSP ones Outline: Simplify the way we update editors after the LSP starts Outline: Add methods to stop symbol services Outline: Rename a method for clarity Testing: Check that all files in the Outline are updated at startup Testing: Some small test fixes LSP: Fix error in variable Testing: Use a better method to check the spinner is not shown in a couple of Outline tests Rename files in scripts dir because now we only support Python 3 Setup.py: Drop support for Python 2 Remove some extra references to Python 2 Remove troubleshooting guide because it's now in our docs Outline: Update editors when switching projects Testing: Check that outline is updated after closing a project Preferences: Apply window style option only if it changes in Appearance Preferences: Remove options that break the interface or are unnecessary Outline: Catch error when updating editors after switching projects Testing: Fix a failing test Create all clean directories in a single subfolder inside tempdir Main Window: Catch TypeError when loading third-party plugins Preferences: Remove another option that it's not worth to make it configurable Kernel spec: Don't pass PYTHONPATH directly to the kernel git subrepo clone --branch=set-spyder-pythonpath --force https://github.com/ccordoba12/spyder-kernels.git external-deps/spyder-kernels Testing: Check that a file with a std library name, and added through our PYTHONPATH manager, doesn't break the console git subrepo clone (merge) --branch=1.x --force https://github.com/spyder-ide/spyder-kernels.git external-deps/spyder-kernels Utils: Remove ipyconsole kwarg to add_pathlist_to_PYTHONPATH Utils: Remove usage of old_pypath in add_pathlist_to_PYTHONPATH Utils: Drop env by default in add_pathlist_to_PYTHONPATH Testing: Add a test for add_pathlist_to_PYTHONPATH git subrepo pull external-deps/python-language-server IPython console: Remove pager option because it's broken IPython console: Remove PageControlWidget because it's not necessary anymore IPython console: Catch an error when trying to restart the kernel git subrepo pull external-deps/python-language-server Main Window: Remove short name assignments for CONF.get/set Main Window: Improve style and docstrings of several layout related methods Get better diffs for Python files Main Window: Use current size and position when saving window settings Fix style issues reported by pep8speaks Pylint: Don't try to reload analysis for the currently displayed file Main Window: Improve message about new releases Outline: Use current options to update view Outline: Use update_all_editors when changing options Snippets: Fix error when trying to get snippets for the current word Snippets: Increase size of some widgets LSP: Move code formatting and snippets tabs after doctring style one Snippets: Add tooltip to elements in snippets table LSP: Rename widget config files Change priority of snippets to be below normal completions Snippets: Change order of def snippets Fix style issues reported by pep8speaks Projects: Catch an error when stopping watcher Fix minor style issues Outline: Only update configuration or editors when necessary Outline: Reset editors' info when changing comments and group cells options More style fixes Outline: Remove unnecessary methods Snippets: Add name and value to base node class Fix errors in translation strings Update translation files Testing: Remove unused imports and variables git subrepo clone --branch=symbols-no-init --force https://github.com/ccordoba12/python-language-server.git external-deps/python-language-server Remove block comments Testing: Add a test to get symbols in a file not part of a module Main window: Resstore mention to our installation guide in message about new release Fix PyLS subrepo remote git subrepo pull external-deps/python-language-server git subrepo clone --branch=develop --force https://github.com/palantir/python-language-server.git external-deps/python-language-server Editor: Change default auto-formatter to be Black Update translations Fix detection of conda and pyenv environments on Windows Report correctly Windows app interpreter Use run_program instead of raw subprocess in get_interpreter_info Fix detection of conda envs when conda is not in PATH Don't show path for undetected conda interpreters LSP: Fix setting edge line when changing auto-formatters Config: Revert default autoformatter to autopep8 Editor: Set edge line only if columns value is different from None git subrepo clone --branch=fix_warning --force https://github.com/impact27/spyder-kernels.git external-deps/spyder-kernels git subrepo clone (merge) --branch=1.x --force https://github.com/spyder-ide/spyder-kernels.git external-deps/spyder-kernels Tour: Adjust its dialog style differently for Mac and Windows/Linux Tour: Remove Help button from dialog Fix logging to a file Back to work Shortcuts: Remove usage of super() for compatibility with Python 2 Set upper constraint on our dependencies to maintain compatibility with Python 2 Update PyLS and spyder-kernels versions for 4.2 Update Changelog Update Announcements Release 4.2.0 Daniel Althviz Moré (1): Installer: Code review docstring suggestions Diego Prosperi Turibio (11): ENH: add option insert above/bellow in variable explorer closes: #13371 FIX: resolving pep8 issues. FIX: resolving pep8 issues. FIX: resolving pep8 warnings. FIX: resolving pep8 warnings. FIX: resolving pep8 warnings. corrected grammatical errors FIX: insert above/below applied just for lists FIX: resolved styling issues FIX: formatting issue FIX: formatting issue Edgar Andrés Margffoy Tuay (105): Compute diff between symbols across codeeditor changes Remove f-string Manage to display symbols in the outline explorer Fix tree update logic Re-enable click and cursor following functions Remove semicolons Fix style issues Remove f-strings Fix switching regression Update widget tests Add LSP + OutlineExplorer test Remove tests Mark test as second Remove extra text that cannot be retrieved without LSP Remove more unused strings Add calls to handle textDocument/formatting call Add formatter options to configpage Implement removal of trailling whitespaces/adding newline at the end Add three-merge as dependency for merging document changes Add source menu action, right-click action and shortcut Implement documentRange formatting Format whole document when range formatting is not available Propagate formatting enable/disable menus across all places Update shortcut Add yapf, autopep8 and pyls-black to dependencies Remove pyls-black from conda.txt temporarily Add missing comma Fix call to super for focusInEvent Prevent AttributeError Disable black by pyls_black Add test Define settings tab layout Add JSON validation for import Improve snippet import messages Update snippets table when switching language Skip module definitions on Python git subrepo clone --branch=fix_method_attribute_symbols --force https://github.com/andfoy/python-language-server.git external-deps/python-language-server Remove os and sys Add loading spinner and fix issues with multi-line class imports git subrepo clone --branch=fix_method_attribute_symbols --force https://github.com/andfoy/python-language-server.git external-deps/python-language-server git subrepo clone --branch=fix_method_attribute_symbols --force https://github.com/andfoy/python-language-server.git external-deps/python-language-server Remove commented sections Do not include imports as part of tests Set include import symbols option to Fals git subrepo clone --branch=fix_method_attribute_symbols --force https://github.com/andfoy/python-language-server.git external-deps/python-language-server git subrepo clone --branch=fix_method_attribute_symbols --force https://github.com/andfoy/python-language-server.git external-deps/python-language-server Address review comments Remove yapf and autopep8 from setup Add waiting spinner and set editor in read-only mode Add autoformat on save option Minor error correction Add index to params Remove yapf and autopep8 from conda.txt Update Binder dependencies Display an error message when Kite sends a non-dict response Improve message layout Add pyls-spyder as a dependency Hide outline explorer spinner for file that do not have lsp support Add an option to hide variables Address PEP8 style issues Remove pip flags Update test asset Add option to hide/display innermost element Add pyls-spyder to conda requirements Add pyls-spyder to binder dependencies Use >= on all dependencies Address review comments Improve non innermost expansion Update root selection Disable attributes when variables are disabled Do not run under pytest Update formatter across all menus Fix read-only parenthesis issue Fix issues with duplicated text Address review comments Prevent the insertion of extra newlines when formatting Remove pyls-black version pinning Fix tests Fix range tests Fix remove_trailing_spaces method and attribute clash Fix minor issues regarding the configpage Fix class snippet Fix issues with reset Prevent snippet overwriting when restoring defaults Add text snippets completion plugin Add snippets test Add codeeditor test Move error message to Kite plugin Fix style issues Minor error correction Fix for None Set pyls-spyder version to 0.1.1 Add follow cursor option Remove old key in test Set display variables to False Propagate pyls-spyder settings Address review comment React to group/ungroup cells Address review comments Address remaining comments Update lambda git subrepo pull external-deps/python-language-server Reindent completions before inserting them Prevent errors with Kite Prevent code snippet search from picking the root text node Jean-Sébastien Gosselin (20): RunConfigOptions: Create browse button with create_toolbutton RunConfigOptions: fix content vertical stretch RunConfigOptions: remove horizontal line BaseRunConfigDialog: Remove the ? button in the window bar. RunConfigDialog: set widget resizable in scrollarea RunConfigDialog: llimit combobox horiz stretch Minor codestyle changes RunConfigDialog: Fix combobox horizontal size policy Revert "RunConfigDialog: llimit combobox horiz stretch" Remove contents margin ofo RunConfigOptions only in multiple files setup RunConfigOneDialog: Set widget resizable in single mode ProjectDialog: use create_toolbutton for the 'select location' button ProjectDialog: remove window context help button hint projectdialog: update and sort QtWidgets imports AboutDialog: remove WindowContextHelp button AboutDialog : make text selectable AboutDialog: scale spyder logo better using smooth transform instead of fast AboutDialog: don't hardcode dialog size change dialog icon to fit that used in the Help menu AboutDialog: set a fixed width for the label Juanita Gomez (8): Apply suggestions from code review Apply suggestions from last code review Apply suggestions from code review Update spyder/plugins/editor/widgets/editor.py Apply suggestions from code review Apply suggestions from code review Update spyder/app/mainwindow.py Apply suggestions from code review Matúš Sabat (1): 13957 Change replace boxes Oscar Gustafsson (6): Added get_package_version for more complete version list Default versions and pkg_resoruces dependency added Changed dependency from pkg_resources to setuptools Added version requirement for setuptools Removed PyYAML deprecation warning and sorted dependencies Added test for get_module_version Quentin Peter (83): do_where git subrepo clone --branch=do_where --force https://github.com/impact27/spyder-kernels.git external-deps/spyder-kernels git subrepo clone --branch=do_where --force https://github.com/impact27/spyder-kernels.git external-deps/spyder-kernels add test git subrepo clone --branch=do_where --force https://github.com/impact27/spyder-kernels.git external-deps/spyder-kernels fix test fix test git subrepo clone (merge) --branch=do_where --force https://github.com/impact27/spyder-kernels.git external-deps/spyder-kernels Separate cmd input from general io git subrepo clone --branch=no_exclamation --force https://github.com/impact27/spyder-kernels.git external-deps/spyder-kernels Fix history exclamation git subrepo clone --branch=no_exclamation --force https://github.com/impact27/spyder-kernels.git external-deps/spyder-kernels Add local namespace test fix test Apply review comments move import Don't save single pdb commands emit executing don't add pdb commands to history test close button skip test on windows Fix transient NameError fix NameError count recursive add test git subrepo clone --branch=no_exclamation --force https://github.com/impact27/spyder-kernels.git external-deps/spyder-kernels git subrepo clone --branch=no_exclamation --force https://github.com/impact27/spyder-kernels.git external-deps/spyder-kernels fix test use self.is_debugging git subrepo clone --branch=no_exclamation --force https://github.com/impact27/spyder-kernels.git external-deps/spyder-kernels add blank line longer wait time Update spyder/plugins/ipythonconsole/widgets/debugging.py git subrepo clone (merge) --branch=1.x --force https://github.com/spyder-ide/spyder-kernels.git external-deps/spyder-kernels git subrepo clone (merge) --branch=1.x --force https://github.com/spyder-ide/spyder-kernels.git external-deps/spyder-kernels git subrepo clone --branch=no_exclamation --force https://github.com/impact27/spyder-kernels.git external-deps/spyder-kernels fix test and reorder imports git subrepo clone --branch=no_exclamation --force https://github.com/impact27/spyder-kernels.git external-deps/spyder-kernels revert changes pyls skip test on win set debug events to True set debug events to True git subrepo clone --branch=no_exclamation --force https://github.com/impact27/spyder-kernels.git external-deps/spyder-kernels stop heartbeats on deletion remove skip test git subrepo clone --branch=no_exclamation --force https://github.com/impact27/spyder-kernels.git external-deps/spyder-kernels test leading indent Add an execute queue pep8 git subrepo clone --branch=fix_12651 --force https://github.com/impact27/spyder-kernels.git external-deps/spyder-kernels remove fixture debug git subrepo clone (merge) --branch=1.x --force https://github.com/spyder-ide/spyder-kernels.git external-deps/spyder-kernels fix comment Fix test collectioneditor Add numbered prompt and single letter mode Add ! prefix for pdb and create a debug preferences section Update the tests for the PR git subrepo clone --branch=separate_cmd_input --force https://github.com/impact27/spyder-kernels.git external-deps/spyder-kernels remove one parenthesis IPdb Apply suggestions from code review fix not normed brakpoints fix pdb arrow remove single letter explore mode git subrepo clone --branch=separate_cmd_input --force https://github.com/impact27/spyder-kernels.git external-deps/spyder-kernels remove explore mode test check falls back on pdb commands remove unused shortcut Fix history filtering Fix silent_execute pep8: Limit line length bump CONF_VERSION git subrepo clone (merge) --branch=separate_cmd_input --force https://github.com/impact27/spyder-kernels.git external-deps/spyder-kernels Skip error namespace browser git subrepo clone --branch=fix_error_get_value --force https://github.com/impact27/spyder-kernels.git external-deps/spyder-kernels Add display error raise Keyerror git subrepo clone --branch=1.x --force https://github.com/impact27/spyder-kernels.git external-deps/spyder-kernels add docstring git subrepo clone (merge) --branch=1.x --force https://github.com/spyder-ide/spyder-kernels.git external-deps/spyder-kernels change default value for pdb_use_exclamation_mark git subrepo clone --branch=separate_cmd_input --force https://github.com/impact27/spyder-kernels.git external-deps/spyder-kernels git subrepo clone (merge) --branch=1.x --force https://github.com/spyder-ide/spyder-kernels.git external-deps/spyder-kernels Fix get_package_version Ryan Clary (44): * update running_in_mac_app * move standalone mac app creation script to mac-application repo * remove obsolete code; prevent Spyder.py from opening upon app launch * update Variable Explorer error message for clarity in Mac application instances. * resolve conversation spyder-ide/spyder#12011 (comment) * display interpreter status in statusbar, even if it isn't a conda interpreter or spyder isn't started from conda environment. * fix mocker for internal and other interpreter tests * if env keyword passed to subprocess, make sure that windows subprocess gets SYSTEMROOT env variable * call python subprocesses with clean environment to ensure appropriate versions are extracted. * resolves conversation spyder-ide/spyder#12235 (comment) * resolves conversations spyder-ide/spyder#12235 (comment) and spyder-ide/spyder#12235 (comment) * resolves conversation spyder-ide/spyder#12235 (comment) * resolve conversation spyder-ide/spyder#12235 (comment) * resolves conversation spyder-ide/spyder#12235 (comment) * explicitly set kernel environment variables * kernel should not inherit PYTHONPATH from Spyder's runtime environment * Jedi environments groomed to properly work with external environments * cleanup obsolete imports * remove support for Python 2 * fix issue where external consoles would not launch * initial migration of mrclary/mac-application * clean up dmg settings * add github action * must use pip3/python3 * forgot uninstall flags * corrections per PR conversations * added default shell and working-directory * increase detach_retries from 5 (default) to 30. * pip is not included in the standalone, so no need to exclude it. * use subrepo spyder-kernels and PyLS on pull request; use release versions on spyder release * use matrix strategy * refactor setup.py * update documentation * py2app must have spyder package in working directory * remove commented workflow job step * fixed issue for full build version "Library not loaded: @loader_path/.dylibs/libjpeg.9.dylib" * setuptools=50.3.2 does not cause problems for app bundle. Sometime after 40.0.0 and before 50.3.2, this was fixed. * fix "Mandatory: pyls_black >=0.4.6 : None (NOK)" * temporarily add paths to PATH when checking if a program is installed. This permits general use without assuming that user profile is sourced (e.g. .bash_Profile), such as in macOS application. * update get_list_conda_envs since find_program checks required paths * do not modify os.environ['PATH'] * Fix issue where conda environments are not discovered in macOS application. subprocess requires clean environment (probably PYTHONHOME issue) * updates per review conversations * include blib2to3 in PACKAGES; resolves "KeyError: 'blib2to3/Users/rclary/Library/Caches/black/20.8b1/Grammar3.8.6.final.0.pickle'" Spyder bot (1): Update and compile translations Stephannie Jimenez (45): Fix height of run dialog Fix messages shown in plain text in the help pane Fix switch to editor in combo at the start add scrollarea to runconfig dialog per file handle IndexError in pylint history only highlight the ocurrences in the editor Update version of qtconsole to 4.7.7 Remove show all files option from the hamburger menu remove remaining of show all functionality from the explorer tree widget Change hamburguer menu description to edit filter settings Change to python file as description add reset button and description to the filter dialog in the explorer pane add filter button in the toolbar fix pep8 and test update dependency of pandas version to 1.1.1 add description to filter dialog fix variable spelling fix pep8 Only try to get value.time() if the value is a date object add regression test Add review fixes and enhance the files preference configpage Change the glob link and add minor suggestions add utility to find all the conda environments in the system with their path and python version add discovery of pyenv environments remove unused import add graphic menu move interpreter selection to preferences remove unused option merge both combobox options into one with all the entries add review comments fix tests fix pep8 Add fix for Spyder.app handle new environments apart from the detected ones add strip to output from subprocess enhance test and add fix for Spyder.app move functions to avoid circular import add prints in test fix tests fix Windows test add print skip failing test in Windows enhance autoformatter Send max line length option to black Move Show vertical line option under code style tab bnavigator (1): press enter on completion test dalthviz (38): git subrepo clone (merge) --branch=1.x --force https://github.com/spyder-ide/spyder-kernels.git external-deps/spyder-kernels git subrepo clone (merge) --branch=1.x --force https://github.com/spyder-ide/spyder-kernels.git external-deps/spyder-kernels Icons: Test icons dict to check icon's sets naming changes Installer: Config file for Windows Update wheels version and add pywin32 imports as packages Installer: Use Python 3.7.9 Installer: Add script to generate installer (based on the Mu 'win_installer' script) Installer: Update script. Add pip and setuptools update as step Installer: Remove .cfg, Add script to NANIFEST.in Installer: Drop PYTHONPATH when staring a kernel. Add flag to suppress warning Installer: Add way to create installer with list of extra packages Installer: Fix PYTHONPATH management. Add GA workflow file Installer: Improve is_pynsist function. Change yarg installation Installer: Make file executable Installer: Use setup-python Installer: Add NOTICE update and license info of base resources used to create the script Installer: NOTICE and workflow update GA testing Installer: Update workflow. Ignore installer script due his license Installer: Update workflow for release artifact upload Installer: Change dir structure for the installer. Add README instead of NOTICE change Installer: Update setup.cfg Installer: Add build for installer with extra packages Installer: Install external dependencies Installer: Add suffix arg for the Windows script Installer: Update executable name definition in workflow Installer: Add ADD_PACKAGES to support external deps (pyls, spyder_kernels) Installer: Install wheel in the win installer env Installer: Add support for editable packages installs Installer: Fix PYTHONPATH issue. Try adding black dependencies to the workflow Installer: Test black dist.info addition to prevent errors with the pyls Installer: Only install spyder-kernels from the external-deps dir on PRs Installer: Use None for watchdog and intervaltree dependencies in pynsist installations Installer: Add assets for the installer (black dist.info, jedi patch, spyder.nsi script to overwrite files). Improve version handling and installer naming Installer: Fix code style issues Update CHANGELOG.md Release 4.1.6 Back to work goanpeca (2): Fix failing test and fix codestyle Skip tests that only work on mac juanis2112 (46): Change colors of help pane usage message according to ux review Add home button to return to usage message of help pane Switch home button to be next to object field Change tooltip of PYTHONPATH manager to match title in dialog Disable toolbar fullscreen action for macOS Fix Pep8 Add tutorial videos to help menu, update link to troubleshooting in docs Change icon for tutorial videos and fix sentence case Add extra panes and ending message, change position of tips Fix missing panes in tour Maximize/restore screen when opening/closing tour Reset layout and fullscreen when opening/closing tour Fix fullscreen verifications for tour Remove list of tours from menu and close tour in mac when losing focus Fix canvas bug in windows Fix fullscreen restoring on windows/linux and fix update flickering Apply suggestions from code review Add docs link to init and fix style issues Add handle fullscreen function Fix red square around left widgets in editor in tour Fix links in tour Remove running code in tour for ipython console to avoid bug Fix disabling run button of ipython console in tour for macOS Change Kite dialog to tour dialog when starting Spyder for first time Set up tour message for Spyder starting only first time not in dev mode Fix pep8 issues Don't show tour message in safe-mode Set up constant for the default tour Change colors for kernel errors in Ipython console CHange colors for kernel error in ipython console light mode Add shortcuts to profiler and code analysis Fix tests by changing number of shortcuts in pylint table Add warning dialog for xdg-file in external file explorer Add safe-mode option to Spyder in non dev mode. Make hash id a constant Reorganize imports in start.py to make tests in mainwindow run independently Restore safe-mode in boostrap Refactor getting cli_options and cli_args Move reset to app/start.py to allow using it without reading our config file Customize tour dialog when starting spyder Fix project opening when starting spyder in mac app Change font size to pixels for uniformity and change text width for keeping under two lines Add find_git function for macOS to verify correctly if git is installed Avoid command line tools dialog when starting spyder Fix separated strings to allow translations Fix Qlabel string to remove from translation files skjerns (6): fixed sorting of types fixed sorting of types remove debug prints make PEPBOT happy pep happy (2) added dropbox fix

mrclary mentioned this pull request Apr 9, 2020

PR: Initial changes to create again a macOS standalone app #12011

Merged

3 tasks

mrclary force-pushed the clean-subprocess branch 4 times, most recently from 1d8c769 to 966651e Compare April 11, 2020 00:23

goanpeca reviewed Apr 12, 2020

View reviewed changes

spyder/plugins/ipythonconsole/plugin.py Outdated Show resolved Hide resolved

mrclary mentioned this pull request Apr 12, 2020

MacApp: add site-packages to jedi configuration #12271

Closed

3 tasks

mrclary force-pushed the clean-subprocess branch 2 times, most recently from 482caa1 to 0352268 Compare April 16, 2020 15:30

mrclary force-pushed the clean-subprocess branch from 0352268 to b398df1 Compare April 30, 2020 18:30

mrclary mentioned this pull request May 7, 2020

Revive this Repository spyder-ide/mac-application#3

Closed

mrclary force-pushed the clean-subprocess branch from b398df1 to bfa065f Compare May 8, 2020 07:03